datatracker icon indicating copy to clipboard operation
datatracker copied to clipboard

Several pages show ical icons for meetings that have not yet been scheduled

Open rjsparks opened this issue 3 years ago • 1 comments

Once the object for a IETF meeting exists, and a session request has been made, creating a Session object for a group for that meeting, but before even a preliminary meeting agenda has been created, an ical icon shows up on the related meeting pages for the session even though it hasn't been scheduled, and has no times to include in the ical.

The presentation of the link should be gated with there being something relevant to actually provide.

rjsparks avatar Sep 09 '22 14:09 rjsparks

Possible counterargument - if the view that provides the ics simply returns an empty calendar until something is available, people can add sessions to their calendar subscriptions and they will just show up once the session is scheduled.

However, having a link that returns an empty calendar probably violates the principle of least surprise.

rjsparks avatar Sep 09 '22 14:09 rjsparks

@jennifer-richards Have the recent changes affected this?

rjsparks avatar Mar 06 '23 21:03 rjsparks

This seems to have been fixed on group meetings pages (https://datatracker.ietf.org/wg/<acro>/meetings/), where only future "sched" meetings have an ical link.

On the individual session pages (https://datatracker.ietf.org/meeting/<num>/session/<acro>), ical links are shown regardless.

jennifer-richards avatar Mar 06 '23 21:03 jennifer-richards

On the individual session pages (https://datatracker.ietf.org/meeting//session/), ical links are shown regardless.

We should be consistent, and "no link when unscheduled" seems to be winning, so the above should have an if statement added.

rjsparks avatar Mar 07 '23 16:03 rjsparks