datatracker icon indicating copy to clipboard operation
datatracker copied to clipboard

update timestamp for meeting agendas seem incorrect

Open ghwood opened this issue 3 years ago • 5 comments
trafficstars

What happened?

The last updated timestamp seems to be too far in the past.

It also should use either the user's local timezone or UTC.

Attached is a screenshot of https://datatracker.ietf.org/meeting/114/agenda/ taken on 2022-04-20 at 9:45 in a EDT.

image

What browser(s) are you seeing the problem on?

Safari

Code of Conduct

  • [X] I agree to follow the IETF's Code of Conduct

ghwood avatar Apr 20 '22 13:04 ghwood

I believe the 1970-01-01 date is because there is not yet an agenda for IETF 114. This should probably be indicated instead of displaying a bogus timestamp. For https://datatracker.ietf.org/meeting/113/agenda/, the date shows as "Updated: 2022-03-23 at 7:52:27 (PDT)" which is plausible (but still fixed to US Pacific time rather than something sensible for the user or meeting).

jennifer-richards avatar Apr 20 '22 13:04 jennifer-richards

Poking, there's an attempt to hide the "updated" indicator if meeting.updated() is not defined. Unfortunately, the updated() method returns 1970-01-01T00:00:00 rather thanNone in that situation, which defies the effort.

jennifer-richards avatar Apr 20 '22 14:04 jennifer-richards

I think if you get back exactly that datetime, you an just say "it means this wasn't updated". What will be returned when we become TZ aware?

rjsparks avatar Jul 20 '22 21:07 rjsparks

It localizes to PRODUCTION_TIMEZONE, so won't change due to the USE_TZ settings. It'd be nice to change it to be explicitly UTC instead of something that depends on settings.py if we want to use a magic number.

We could instead/also just say that anything before [date after Jan 2, 1970 and before plausible update time] is too long ago to be plausible. That'd avoid depending on a particular time zone for the view.

jennifer-richards avatar Jul 21 '22 02:07 jennifer-richards

Hackearon

Osoted56 avatar Aug 14 '22 07:08 Osoted56