datatracker icon indicating copy to clipboard operation
datatracker copied to clipboard

Automatically pointing to yang modules from drafts is broken leaving stale data

Open ietf-svn-bot opened this issue 4 years ago • 3 comments

type_defect | by [email protected]


At one point, the submit code added additional URLs to a document's page when it contained yang modules.

That is no longer happening, and as a result, these URLs (now external resources) are not being updated as drafts are revised.

The result is a lot of stale data on a bunch of draft's pages:

In dc22fb842160a0c0387457a61838e807e01c8c4a: Counter(DocExtResource.objects.filter(name__name__icontains='yang').val
    ...: ues_list('name',flat=True))
Outdc22fb842160a0c0387457a61838e807e01c8c4a: Counter({'yc_entry': 676, 'yc_impact': 415})

I see some likely settings that some earlier bit of code was probably using that are now not used at all:

/Users/rjsparks/ietf/datatracker/rjs/7.26.1.dev0/ietf/settings.py:
  819 
  820  SUBMIT_YANG_CATALOG_MODULEARG = "modules[]={module}"
  821: SUBMIT_YANG_CATALOG_IMPACT_URL = "https://www.yangcatalog.org/yang-search/impact_analysis.php?{moduleargs}&recurse=0&rfcs=1&show_subm=1&show_dir=both"
  822  SUBMIT_YANG_CATALOG_IMPACT_DESC = "Yang impact analysis for {draft}"
  823  SUBMIT_YANG_CATALOG_MODULE_URL = "https://www.yangcatalog.org/yang-search/module_details.php?module={module}"

So, there's some cleanup needed.

Is it worth restoring the behavior that automatically added and refreshed the pointers, or can people find the modules well enough without them?


Issue migrated from trac:3198 at 2022-03-04 08:11:20 +0000

ietf-svn-bot avatar Feb 26 '21 20:02 ietf-svn-bot

@[email protected] edited the issue description

ietf-svn-bot avatar Feb 26 '21 20:02 ietf-svn-bot

@[email protected] changed status from new to accepted

ietf-svn-bot avatar Mar 03 '21 15:03 ietf-svn-bot

This seems to have gone off the rails around https://github.com/ietf-tools/datatracker/commit/b51de663247a6ad9e942830d28160332e57381b4

rjsparks avatar Aug 01 '22 19:08 rjsparks