datatracker
datatracker copied to clipboard
ietf-tools
The notion of "active ads" is implemented in too many places
keyword_sprint type_defect | by [email protected]
There are more than a dozen places in the code where querysets are constructed to select the currently active ads. There are variants of that selection that include Person objects with pre-ad roles. The logic defining is also captured in the active_ad_positions method.
This should be refactored to capture the logic in one place and allow it to be conveniently used in those others.
Issue migrated from trac:1576 at 2022-03-04 03:58:53 +0000
@[email protected] commented
This is a moderate, to large task (may be bigger than a sprint). Regression will have to be carefully tested.
A good initial sprint activity would be to comb the codebase for where these functions are, and gather a list of them in this ticket.
While active_ad_positions is no longer in the codebase, the following files have a notion of active ads and/or pre-ads: ietf/community/forms.py ietf/doc/forms.py ietf/doc/templatetags/ietf_filters.py ietf/doc/utils.py ietf/doc/views_bofreq.py ietf/doc/views_charter.py ietf/doc/views_conflict_review.py ietf/doc/views_draft.py ietf/doc/views_draft.py ietf/doc/views_search.py ietf/doc/views_search.py ietf/doc/views_search.py ietf/doc/views_status_change.py ietf/group/forms.py ietf/group/views.py ietf/iesg/views.py ietf/ietfauth/utils.py ietf/nomcom/utils.py ietf/person/models.py ietf/person/utils.py ietf/secr/telechat/views.py
The following import get_active_ads from ietf.person.utils: ietf/doc/tests_ballot.py ietf/doc/tests_irsg_ballot.py ietf/doc/tests_rsab_ballot.py ietf/doc/views_search.py
