iequidoo
iequidoo
@dependabot merge
> general comment: please describe a description for your PRs, summarizing the motivation/reason and the approach/solution. Added a commit message. Yes, i hurried to share this work. Actually it should...
> I have mixed feelings about chat deletion, users might expect it to delete all imap emails / messages from that chat too. > > I wouldn't sync chat deletion...
There may be a problem with synchronising chats deletion -- if another device has `DeleteServerAfter` set, messages wouldn't be deleted from the server as a user might think. But this...
> @iequidoo i find pr descriptions as "some discussions here and there" without some additional words hard for reviewers, it would be good to always have at least a handful...
Also i can just remove the last commit so that there will be random suffixes, but not whole filenames. Anyway now we can get files with random suffixes from `dc_msg_get_file()`...
Removed the last commit to unblock merging this
`test_verified_oneonone_chat_enable_disable` suddenly failed: https://github.com/deltachat/deltachat-core-rust/actions/runs/8255079330/job/22580740709?pr=4583
> @flub Could you rebase it or redo it on top of the current `stable`? I am going through oldest PRs and this one seems to be stale. I guess...
> I looked a bit at the failures now. And while I could fix them I'm a bit unsure how to proceed: > > The failures occurring are because async...