video2dataset icon indicating copy to clipboard operation
video2dataset copied to clipboard

FrameSubsampler broken in version 1.3.0

Open libeanim opened this issue 4 months ago • 10 comments

When adding the FrameSubsampler to the config

subsampling:
    FrameSubsampler:
        args:
            frame_rate: 5
            downsample_method: 'fps'
            encode_format: 'mp4'

I get following error message:

Traceback (most recent call last):
  File "/home/evobits/miniconda3/envs/laion/lib/python3.9/site-packages/video2dataset/workers/download_worker.py", line 102, in __call__
    self.download_shard(row)
  File "/home/evobits/miniconda3/envs/laion/lib/python3.9/site-packages/video2dataset/workers/download_worker.py", line 161, in download_shard
    writer_encode_formats["video"] = self.subsamplers["video"][0].encode_formats["video"]
AttributeError: 'FrameSubsampler' object has no attribute 'encode_formats'
shard ./TEST/results2/_tmp/9.feather failed with error 'FrameSubsampler' object has no attribute 'encode_formats'

Is this a typo in the download_worker.py or is there an issue with my config?

libeanim avatar Feb 09 '24 17:02 libeanim