goodfirstissues icon indicating copy to clipboard operation
goodfirstissues copied to clipboard

'Filter by Number of Stars' Button is not working as expected

Open abdul-haseeb-HSB opened this issue 1 year ago • 5 comments

'Filter by Number of Stars' Button is not working as expected

Expected Behavior:

Should be displaying repos as per the user's entered number

Current Behavior:

BUG

  • Displaying Random Repos regardless of the repo
  • If all fields are selected, entering number of stars doesn't make any difference
  • How to Regenerate -> Video Demo

Enhancements

  • No form validation
  • User should only be allowed to enter the numeric value, currently it is accepting and processing all type of values.
  • This can lead to SQL Injection attack as well
  • How to Regenerate -> Video Demo

abdul-haseeb-HSB avatar Jun 13 '24 16:06 abdul-haseeb-HSB

The field is intended to represent a Minimum Number, not an exact match.

I've changed the wording on the Input Label to make it less confusing, and I've also given the input field type="number" to only allow numeric values.

https://github.com/iedr/goodfirstissues/pull/69

KeithBrosch avatar Jun 19 '24 02:06 KeithBrosch

Hey @abdul-haseeb-HSB , Could you please assign this issue to me??

shivansh84ya avatar Jul 02 '24 08:07 shivansh84ya

Hey, I have a pr that fixs this issue by adding a maximal value to the repo star filter session pull request #70

MonsieurRadiant avatar Jul 02 '24 09:07 MonsieurRadiant

Hi , could you please assign it to me , so that i can work on this issue

abhedanil avatar Jul 14 '24 08:07 abhedanil

Hi @abdul-haseeb-HSB What if we'll change totally,

  1. We can set ranges of the Number of stars
  2. User selects the particular range section and will get the repos accordingly

Ravi0529 avatar Dec 16 '24 09:12 Ravi0529