'Filter by Number of Stars' Button is not working as expected
'Filter by Number of Stars' Button is not working as expected
Expected Behavior:
Should be displaying repos as per the user's entered number
Current Behavior:
BUG
- Displaying Random Repos regardless of the repo
- If all fields are selected, entering number of stars doesn't make any difference
- How to Regenerate -> Video Demo
Enhancements
- No form validation
- User should only be allowed to enter the numeric value, currently it is accepting and processing all type of values.
- This can lead to SQL Injection attack as well
- How to Regenerate -> Video Demo
The field is intended to represent a Minimum Number, not an exact match.
I've changed the wording on the Input Label to make it less confusing, and I've also given the input field type="number" to only allow numeric values.
https://github.com/iedr/goodfirstissues/pull/69
Hey @abdul-haseeb-HSB , Could you please assign this issue to me??
Hey, I have a pr that fixs this issue by adding a maximal value to the repo star filter session pull request #70
Hi , could you please assign it to me , so that i can work on this issue
Hi @abdul-haseeb-HSB What if we'll change totally,
- We can set ranges of the Number of stars
- User selects the particular range section and will get the repos accordingly