simona icon indicating copy to clipboard operation
simona copied to clipboard

Properly fix CheckWindow duration

Open sebastian-peter opened this issue 6 months ago • 0 comments

With #875, a fix has been introduced that does not actually get to the root cause of the problem. Now we're just fixing a duration in CheckWindowPassed that has been calculated wrong from the beginning.

The actual problem lies in RuntimeNotifier#completing:

https://github.com/ie3-institute/simona/blob/c2b41b523ec6834dcaa81fde5ee2e40e322251e6/src/main/scala/edu/ie3/simona/scheduler/RuntimeNotifier.scala#L114-L116

Instead of lastStartTime, lastCheckWindowTime should be referenced. That should fix the whole issue (please test though). Parts of #875 can then be reverted.

cc @staudtMarius @danielfeismann

sebastian-peter avatar Aug 23 '24 08:08 sebastian-peter