simona icon indicating copy to clipboard operation
simona copied to clipboard

Have `ChpModel` make use of the new model states

Open danielfeismann opened this issue 1 year ago • 1 comments

I noticed that the HpModel calls calculateNextState in the method calculateActivePower while the ChpModel doesn't. Since both are supposed to stateful maybe that should happen the same way in both models?

Originally posted by @t-ober in https://github.com/ie3-institute/simona/pull/82#discussion_r1168828892

danielfeismann avatar Apr 27 '23 10:04 danielfeismann

I think the underlying problem is that ChpModel makes use of the mutable state of MutableStorage, while it should be converted to use ThermalStorageState like HpModel does. After solving this, MutableStorage and related deprecated functionality should be removed. So to me, this issue is valid, although currently not at a high prio.

sebastian-peter avatar Jan 31 '24 10:01 sebastian-peter