simona icon indicating copy to clipboard operation
simona copied to clipboard

Published 20 hours ago • verified publisher icon ie3-institute

Refactor `WeatherSource` and `WeatherSourceWrapper`

Open sebastian-peter opened this issue 2 years ago • 0 comments

WeatherSource:

  • WeatherSource#apply and WeatherSource#checkConfig can be consolidated. checkConfig is a bad name considering what the method is doing, anyway.
  • Creation of WeatherSourceWrapper in line 344ff can be simplified

WeatherSourceWrapper:

  • The usage of implicits in all WeatherSourceWrapper#apply methods is unnecessary and confusing

There's probably more once one looks deeper into this

sebastian-peter avatar Mar 22 '22 20:03 sebastian-peter