WIP: `/` search navigation and ace jump in rebase/squash/etc

[baggiiiie]

What are you planning to implement?

Here are two features that I have been using lately and enjoying a lot in my local jjui build:

• vim like search navigation (n/N) for /, implementation see baggiiiie/jjui at yc/search-nav
• ace jump for set_parents/duplicate/rebase/squash, implementation see baggiiiie/jjui at yc/ace-jump

NOTE:

• implementation are not finalized, just putting it out here to see if these are features people want
• im, at the same time, getting some mileage on them to see if there's any bugs

Proposed Approach

Briefly describe your planned feature approach:

search navigation

• search navigation (n/N), n for jumping forward and N backward
• highlighting on matched terms

ace jump

User workflow:

1. Press 'r' to enter rebase mode (or 'S' for squash mode)
2. Press 'f' to activate ace jump while staying in rebase/squash mode
3. Type matching keys to jump to a revision
4. After jump completes, return to rebase/squash mode
5. Use existing rebase/squash keys to complete the operation

Testing Strategy

How do you plan to test this implementation?

• Unit tests needed
• Manual testing approach

Breaking Changes

Would this implementation introduce any breaking changes? If so, describe them and any migration strategy.

• No breaking changes

Questions for Discussion

• any ideas/suggestions/feedback are welcome!

Additional Context

Add any other context, mockups, or references that would help reviewers understand your proposal.

search with highlighting and navigation

any text on the screen is search-able!

rebase/squash with ace jump

[idursun]

search navigation (n/N), n for jumping forward and N backward

There's already ' for jumping to the next match, is your implementation going to different from what it does?

[baggiiiie]

@idursun what n is doing is basically ' (i.e., n could be a replacement for '), thought it's more conventional to have n/N since it follows vim's default (and N allows going backwards)