atom-language-idris icon indicating copy to clipboard operation
atom-language-idris copied to clipboard

use idris-ide-client

Open archaeron opened this issue 5 years ago • 16 comments

Work in progress to replace our own ide client with this:

https://github.com/meraymond2/idris-ide-client

archaeron avatar Jun 09 '20 23:06 archaeron

idris-ide-client doesn't handle ipkg files, so I started a project to parse them, so that we can reuse that part too between the atom and the vscode plugin: https://github.com/archaeron/idris-ipkg

archaeron avatar Jun 18 '20 12:06 archaeron

@melted @justjoheinz

could you test this out? :) it's not perfect at all, but baby steps. The code is a lot less complex and many more things are typed

archaeron avatar Jun 25 '20 17:06 archaeron

I'll find some time at the beginning of next week. Glad to test.

justjoheinz avatar Jun 26 '20 05:06 justjoheinz

I'll check it out after work

melted avatar Jun 26 '20 06:06 melted

thank you!

archaeron avatar Jun 26 '20 10:06 archaeron

It's crashing in idris-ide-engine's replyHandler for me. Have to pin it down a bit more.

melted avatar Jun 29 '20 11:06 melted

@melted what OS and idris version are you on? did you remember to do an npm install? (it's a bit annoying that one has to do that)

archaeron avatar Jun 29 '20 20:06 archaeron

Yes, I did npm install (well, after it failed because idris-ide-engine was missing). I used it on windows. I tested with both Idris 1.3.3 and Idris 2.

I'll have some time to debug it tomorrow.

melted avatar Jun 29 '20 22:06 melted

It's really weird, the messages gets sliced up wrong. It connects alright, including parsing the reply. Then when it sends a command (say Open REPL) and it gets an answer 000041(:write-string bla...), it takes 4 as the length and sends 1(:w to replyHandler.

And then it bombs the next time when rite-string bla..) is first in the buffer.

melted avatar Jun 30 '20 09:06 melted

Oh yeah, there's a stray newline in the buffer.

melted avatar Jun 30 '20 09:06 melted

idris2 is not yet supported by meraymond2/idris-ide-client but they are making good progress :)

thanks for testing and reporting the issue on the other repo! I had only tested this on Linux

archaeron avatar Jun 30 '20 15:06 archaeron

@melted I updated to the newest version of the idris-ide-client, where the windows issue should be fixed now

could you test it out again? :)

archaeron avatar Jul 09 '20 17:07 archaeron

Will do!

melted avatar Jul 09 '20 23:07 melted

I had been out of the loop for awhile. After needing to install a typescript peer dependency (I choose npm install --save typescript@^2.0.0) I get startup errors on lines where a question mark is used to check for non null parameters. E.g.

this.holesContainer ? .appendChild(this.prettyprintHoles(holes))

Anyone experienced the same?

justjoheinz avatar Jul 27 '20 12:07 justjoheinz

BTW, I tried the master branch, or which is the current working branch for the ts extensions?

justjoheinz avatar Jul 27 '20 12:07 justjoheinz

typescript version 2.0.0 is really old I'm guessing that's why you're getting those errors) you shouldn't need to install it yourself though. What platform are you testing this on? so that I can try it out too

This is the branch where I try to switch to https://github.com/meraymond2/idris-ide-client. This should streamline our code and we share the implementation of the idris parts with the vscode extension. My plan would be to cut a new version after we've successfully switched.

archaeron avatar Jul 27 '20 15:07 archaeron