Ido M
Ido M
For 2. I don't think it'll be necessary, black font on white background is fine. I think let's try it dynamically, if the text overflows, enlarge the width, if overlapping...
Connected on slack, waiting for a sample PR.
@yafimvo thoughts on making this dynamic? If no ideas, we can take the approach of having the text `grey background color` instead, so at least it's readable.
@e1ha is this the latest code? and is this ready for review?
Try rebasing? We updated mistune a week ago maybe it's related..
I see a flake8 error on the code that doesn't exist. Let's open a new PR and cherry-pick your changes, that should fix that out.
`something off the shelf` like what?
@e1ha I think it's a good point, can you do a short research on what built-in functionality we can leverage here? (instead of reinventing the wheel)
@e1ha I just tested it. I think overall it's good, 3 comments on the photo here. 1. We should center (height/width) the text to the circle. 2. There's a bit...
Why do we need a db here and not just counting end_time - start_time. If we want historical comparisons it makes sense. Or do you mean kind of what we're...