intergram icon indicating copy to clipboard operation
intergram copied to clipboard

Several upgrades! :-)

Open lspohn opened this issue 5 years ago • 3 comments

Hey!

I really like your work and am going to adapt it to our special needs. I try to contribute all changes that might be useful for public.

New Features:

  • All dependencies upgraded to latest version
  • Webpack upgraded to v4
  • HTML, CSS and media has been moved to /static
  • Localization added - detecting browser language and changing all strings dynamically (English as default)
  • Localization strings can be modified by user or default configuration can be used
  • German localization included, other languages can easily be added (just use https://deepl.com/translator ...)
  • Time-of-Day-dependant activation of the widget, 1-2 time windows configurable, e.g 9-11am and 1-4pm (UTC as reference)
  • Users get random name using faker.js (user names are now retrieved from the server via GET) instead of randoms strings (-> makes it easier to remember and distinguish multiple users)
  • Message input box with 4 rows -> should be enough for most messages
  • Some design changes (rounded corners, different font, smaller paddings, different coloring of visitor/admin, consequently using "rem" units)

What could still be done in terms of build infrastructure (nice-to-have but not neccesary)

  • Enabling webpack-dev-server with hot module replacement. Currently, it doesn't work because webpeck doesn't inject it's configuration into the html files. You have to rerun "npm run dev/build/css" after each change and refresh in browser manually, disabling caching.

Project runs fine for me but please test it before accepting the request. ;-)

Regards & thanks, Lucas

lspohn avatar Sep 03 '18 00:09 lspohn

First want to do some more tests tomorrow, then I'll reopen the pull request!

lspohn avatar Sep 03 '18 00:09 lspohn

Wow, this looks very interesting. Let me know when it’s ready and I will start reviewing it.

idoco avatar Sep 03 '18 04:09 idoco

At the end, was this integrated @idoco I think this was already based on how it works, although if multiple visitors check the website and chat, all of them will see the chat of everyone else for some reason.

luisalvarado avatar Sep 23 '21 15:09 luisalvarado