Known-Docker icon indicating copy to clipboard operation
Known-Docker copied to clipboard

first pass update to known-1.0.0/php7.3

Open edrex opened this issue 6 years ago • 5 comments

It builds but is untested.

Issues:

  • Uses tar from @mapkyca's site, is that final?
  • Couldn't figure out what to do with the binary .sha256. Isn't it supposed to be in hex? Also the key you have linked at https://www.marcus-povey.co.uk/known/ (EC8148CF845C2043948FFF81BACB0C9AAA54ED56) isn't the signing key (E3F1C15C43A1E393A4B88C6E20FD53C2397813CA)

Changes:

  • Mariadb client since no mysql in buster
  • mcrypt moved to pecl

I know nothing about modern PHP so please advise what else should be changed, or just fix this up for me :D

edrex avatar Nov 13 '19 08:11 edrex

Ooopsy, I think I had the package built using my personal key. I'll update the key when I get back.

Thanks for this, I'll take a look at it later...

mapkyca avatar Nov 13 '19 10:11 mapkyca

Would it be better to use uncomposed tars from github like https://github.com/egoexpress/docker-known/blob/master/Dockerfile? Could set up a builder for master too that way..

edrex avatar Nov 13 '19 19:11 edrex

Depends on what you're wanting to achieve. If you want to containerise a "release", then use the package. If you want to containerise the bleeding edge code then use a git checkout + composer.

I can see an argument for having both options available, and I for one would find it useful to have a docker image of bleeding edge Known. Especially if it was configured to better mimic a "real world" deploy - e.g. database in a separate container to web, ditto files

mapkyca avatar Nov 14 '19 10:11 mapkyca

PHP 7.4 is now out, so I'd suggest packaging for that as well

mapkyca avatar Jan 05 '20 08:01 mapkyca

Sorry, I haven't gotten back to this and need to focus on other things right now. Feel free to fix up or I'll get to it when I next work on my known blog. :man_facepalming:

edrex avatar Jan 09 '20 00:01 edrex