django-siteflags icon indicating copy to clipboard operation
django-siteflags copied to clipboard

Missing migration for Django 4.x?

Open bioworkflows opened this issue 1 year ago • 1 comments

When I run makemigrations for my own project, django always generates a migration for django-siteflags,

site-packages/siteflags/migrations/0002_alter_flag_content_type_alter_flag_user.py

# Generated by Django 4.2.1 on 2023-06-09 13:57

from django.conf import settings
from django.db import migrations, models
import django.db.models.deletion


class Migration(migrations.Migration):

    dependencies = [
        migrations.swappable_dependency(settings.AUTH_USER_MODEL),
        ("contenttypes", "0002_remove_content_type_name"),
        ("siteflags", "0001_initial"),
    ]

    operations = [
        migrations.AlterField(
            model_name="flag",
            name="content_type",
            field=models.ForeignKey(
                on_delete=django.db.models.deletion.CASCADE,
                related_name="%(app_label)s_%(class)s_flags",
                to="contenttypes.contenttype",
                verbose_name="Content type",
            ),
        ),
        migrations.AlterField(
            model_name="flag",
            name="user",
            field=models.ForeignKey(
                on_delete=django.db.models.deletion.CASCADE,
                related_name="%(class)s_users",
                to=settings.AUTH_USER_MODEL,
                verbose_name="User",
            ),
        ),
    ]

It appears that I can safely ignore this migration but is it something that should be added to siteflags?

bioworkflows avatar Jun 09 '23 14:06 bioworkflows

Thank you for the report.Yeah, it seems that not all model changes are reflected in the existing migrations. You may ignore it since chances are that none of those changes will require db updates.I'll look at it further and probably add the migration, when I came back from the vacation.

idlesign avatar Jun 10 '23 15:06 idlesign