Mostafa Emami

Results 16 comments of Mostafa Emami

As I pointed out in the last comment, this PR doesn't put any limitation on how many properties can be changed atomically. org.freedesktop.DBus.Properties.PropertiesChanged (STRING interface_name, **DICT changed_properties**, ARRAY invalidated_properties); Which...

> Added new test : #305 > Could you please check that your change does not break that test ? > Could you please also squash your commits ? The...

> "serializeOverIPC" is not a good name. Structures are always serialized to be sent over IPC... > I would rather have an annotation on an interface, rather than on the...

@jacky309 Please have another look, all QtDBus stuff moved to DBus layer.

@jacky309 Please let me know if you have any further comments, I assume the current ones are all addressed.

@jacky309 Can you please let me know what is still blocking the merge?