Ian Griffiths

Results 34 issues of Ian Griffiths

Message type values are always in the range 0-47 inclusive, because there are only 6 bits available to hold the message type, and by definition they are non-negative. While all...

The `NmeaAisLongRangeAisBroadcastParser` constructor docs say that it creates a new `NmeaAisPositionReportClassAParser`!

documentation

Although #49 was closed on the grounds that SpecFlow "won't probably use it for a long time", @SabotageAndi did say: >But that doesn't mean, that we would not accept a...

E.g., `DistinctBy` is now built into .NET.

In https://github.com/corvus-dotnet/Corvus.Extensions/pull/53#pullrequestreview-344062016 @mwadams asked me to remove all `ConfigureAwait(false)` calls in specs. However, on further discussion, we now suspect this is no longer required. So we're going to try without...

Our `` and `` entrys are all currently empty. This means the components are not as discoverable as they could be.

IMM

Last review was #51, completed on 16th March 2020

IMM

Baseline GC and perf

IMM

Some methods tested, but the following are not: - `ForEachUntilFalse` - `ForEachUntilFalseAsync` - `ForEachUntilTrue` - `ForEachUntilTrueAsync`

good first issue
IMM

Several methods are untested. Check to see whether they are still relevant, and either delete or add tests.

good first issue
IMM