Alex Pelagenko

Results 99 comments of


                                            Alex Pelagenko

fix(sql): fix incorrect data stored when inserting string literals into numeric columns

#### [PR Coverage check] :heart_eyes: **pass** : 1235 / 1284 (96.18%) #### file detail | |path|covered line|new line|coverage| |----|----|----|----|----| |:large_blue_circle:|io/questdb/griffin/model/RuntimeIntervalModel.java|0|1|00.00%| |:large_blue_circle:|io/questdb/std/Numbers.java|6|12|50.00%| |:large_blue_circle:|io/questdb/std/BytecodeAssembler.java|13|22|59.09%| |:large_blue_circle:|io/questdb/griffin/SqlCompiler.java|101|117|86.32%| |:large_blue_circle:|io/questdb/griffin/SqlCodeGenerator.java|51|59|86.44%| |:large_blue_circle:|io/questdb/cutlass/pgwire/PGConnectionContext.java|16|18|88.89%| |:large_blue_circle:|io/questdb/cairo/ImplicitCastException.java|54|57|94.74%| |:large_blue_circle:|io/questdb/griffin/engine/functions/bind/BindVariableServiceImpl.java|70|71|98.59%| |:large_blue_circle:|io/questdb/griffin/RecordToRowCopierUtils.java|495|498|99.40%| |:large_blue_circle:|io/questdb/cutlass/line/udp/LineUdpParserSupport.java|1|1|100.00%| |:large_blue_circle:|io/questdb/griffin/engine/functions/cast/CastCharToDoubleFunctionFactory.java|2|2|100.00%|...

refactor(core): Refactor ServerMain so that it may be instantiated from a different main block

#### [PR Coverage check] :heart_eyes: **pass** : 774 / 897 (86.29%) #### file detail | |path|covered line|new line|coverage| |----|----|----|----|----| |:large_blue_circle:|io/questdb/network/IODispatcherWindows.java|0|4|00.00%| |:large_blue_circle:|io/questdb/network/MutableIOContextFactory.java|0|1|00.00%| |:large_blue_circle:|io/questdb/network/Kqueue.java|0|4|00.00%| |:large_blue_circle:|io/questdb/cutlass/http/DefaultHttpServerConfiguration.java|0|2|00.00%| |:large_blue_circle:|io/questdb/cutlass/line/tcp/DefaultLineTcpReceiverConfiguration.java|1|5|20.00%| |:large_blue_circle:|io/questdb/cutlass/line/tcp/LineTcpWriterJob.java|1|2|50.00%| |:large_blue_circle:|io/questdb/cutlass/http/processors/JsonQueryProcessor.java|1|2|50.00%| |:large_blue_circle:|io/questdb/cutlass/http/processors/TextQueryProcessor.java|1|2|50.00%| |:large_blue_circle:|io/questdb/mp/Worker.java|5|7|71.43%| |:large_blue_circle:|io/questdb/ServerMain.java|64|84|76.19%| |:large_blue_circle:|io/questdb/cutlass/pgwire/PGWireServer.java|4|5|80.00%|...

Fill not filling values at start or end of time range.

I don't think it's a good idea to start / end date range based on the WHERE limitations. Say you did not specify upper limit for the timestamp in your...

fix(core): fix OOM on start caused by O3 purge backglog

#### [PR Coverage check] :heart_eyes: **pass** : 64 / 74 (86.49%) #### file detail | |path|covered line|new line|coverage| |----|----|----|----|----| |:large_blue_circle:|io/questdb/cairo/ColumnPurgeOperator.java|31|41|75.61%| |:large_blue_circle:|io/questdb/cairo/ColumnPurgeJob.java|33|33|100.00%|

fix(sql): fix UnsupportedOperationException thrown on sample by with invalid values

#### [PR Coverage check] :heart_eyes: **pass** : 11 / 11 (100.00%) #### file detail | |path|covered line|new line|coverage| |----|----|----|----|----| |:large_blue_circle:|io/questdb/griffin/WhereClauseParser.java|1|1|100.00%| |:large_blue_circle:|io/questdb/griffin/SqlCodeGenerator.java|10|10|100.00%|

fix(sql): reduce memory utilization of cursor factories

#### [PR Coverage check] :heart_eyes: **pass** : 190 / 197 (96.45%) #### file detail | |path|covered line|new line|coverage| |----|----|----|----|----| |:large_blue_circle:|io/questdb/griffin/engine/orderby/LimitedSizeSortedLightRecordCursorFactory.java|5|8|62.50%| |:large_blue_circle:|io/questdb/griffin/engine/join/HashJoinRecordCursorFactory.java|4|5|80.00%| |:large_blue_circle:|io/questdb/griffin/engine/join/HashOuterJoinRecordCursorFactory.java|4|5|80.00%| |:large_blue_circle:|io/questdb/griffin/engine/orderby/RecordTreeChain.java|5|6|83.33%| |:large_blue_circle:|io/questdb/griffin/engine/join/AsOfJoinRecordCursorFactory.java|13|14|92.86%| |:large_blue_circle:|io/questdb/griffin/engine/groupby/SampleByFillNoneRecordCursorFactory.java|4|4|100.00%| |:large_blue_circle:|io/questdb/griffin/engine/orderby/SortedRecordCursor.java|8|8|100.00%| |:large_blue_circle:|io/questdb/std/MemoryPages.java|4|4|100.00%| |:large_blue_circle:|io/questdb/griffin/engine/table/AsyncFilteredRecordCursor.java|13|13|100.00%| |:large_blue_circle:|io/questdb/griffin/engine/groupby/SampleByInterpolateRecordCursorFactory.java|2|2|100.00%| |:large_blue_circle:|io/questdb/griffin/engine/orderby/LimitedSizeLongTreeChain.java|9|9|100.00%|...

fix(sql): apply query timeout to insert statements and improve timeout reliability

#### [PR Coverage check] :heart_eyes: **pass** : 276 / 287 (96.17%) #### file detail | |path|covered line|new line|coverage| |----|----|----|----|----| |:large_blue_circle:|io/questdb/cairo/sql/SqlExecutionCircuitBreaker.java|2|3|66.67%| |:large_blue_circle:|io/questdb/griffin/engine/groupby/vect/GroupByNotKeyedVectorRecordCursorFactory.java|26|29|89.66%| |:large_blue_circle:|io/questdb/griffin/SqlCompiler.java|21|23|91.30%| |:large_blue_circle:|io/questdb/cutlass/pgwire/PGConnectionContext.java|44|46|95.65%| |:large_blue_circle:|io/questdb/griffin/engine/table/LatestByAllIndexedRecordCursor.java|65|67|97.01%| |:large_blue_circle:|io/questdb/griffin/engine/groupby/vect/GroupByRecordCursorFactory.java|50|51|98.04%| |:large_blue_circle:|io/questdb/griffin/engine/table/LatestByValueListRecordCursor.java|9|9|100.00%| |:large_blue_circle:|io/questdb/PropServerConfiguration.java|3|3|100.00%| |:large_blue_circle:|io/questdb/griffin/engine/table/LatestByValueFilteredRecordCursor.java|3|3|100.00%| |:large_blue_circle:|io/questdb/griffin/engine/table/LatestByAllRecordCursor.java|2|2|100.00%| |:large_blue_circle:|io/questdb/griffin/engine/table/LatestByValuesRecordCursor.java|2|2|100.00%|...

feat(core): Allow attaching partitions from different volumes

#### [PR Coverage check] :heart_eyes: **pass** : 150 / 160 (93.75%) #### file detail | |path|covered line|new line|coverage| |----|----|----|----|----| |:large_blue_circle:|io/questdb/cairo/TableWriter.java|46|51|90.20%| |:large_blue_circle:|io/questdb/std/str/Path.java|44|48|91.67%| |:large_blue_circle:|io/questdb/cairo/O3PartitionPurgeJob.java|45|46|97.83%| |:large_blue_circle:|io/questdb/std/FilesFacadeImpl.java|3|3|100.00%| |:large_blue_circle:|io/questdb/std/Files.java|12|12|100.00%|

chore(ilp): optimize ILP parser

#### [PR Coverage check] :heart_eyes: **pass** : 36 / 37 (97.30%) #### file detail | |path|covered line|new line|coverage| |----|----|----|----|----| |:large_blue_circle:|io/questdb/cutlass/line/tcp/LineTcpParser.java|36|37|97.30%|

use tcp flow to write data to questdb database with 800 tables will out of memory

It is very primitive as of now, you can do `select dump_memory_usage()` and it will dump some memory breakdown to log file. From top of my head I'd suggest decreasing...