Midi clock stop event does not stop a timeline.

[rvega]

I have something very simple like:

logging.basicConfig(level=logging.INFO, format="[%(asctime)s] %(message)s")

midi_in = iso.MidiInputDevice()
timeline = iso.Timeline(clock_source=midi_in)
timeline.schedule({
    "note": iso.PSequence([ 60, 67, 72, 77, 84 ],
    "duration": 0.5,
    "amplitude": iso.PWhite(0, 128)
}, delay=1)
timeline.run()

And I'm sending midi clock and start/stop events from a DAW.

What I'm trying to achieve is for the timeline/sequence to start/stop when the DAW sends the start/stop events and for it to be synced with the DAW's MIDI clock.

[rvega]

I did some additional tinkering and I set up my DAW to output MIDI song position pointer. Now what i see is:

The timeline responds to the DAW's start messages and tempo settings but when the stop message is received, the timeline keeps going and keeps outputing notes, also the message "Timeline: Stopping" is displayed.

[rvega]

Here's a PR that fixes this issue for me. https://github.com/ideoforms/isobar/pull/23

[ideoforms]

Hey @rvega! Nice to see you here. Sorry for the slow reply, just working through a bit of a PR backlog...

What DAW are you using? I tested the current behaviour with Ableton Live and it works OK. But I've just been doing some reading and it sounds like some devices/DAWs continue to send MIDI clock events even when the transport is stopped, which I suspect may be what you're seeing here.

[rvega]

Hi Daniel! @ideoforms It's been a while since I used isobar, but I was using Bitwig under Arch Linux.

[ideoforms]

Thanks @rvega, that's great, I'll do some tests in Bitwig. This PR looks good though so I anticipate merging. Cheers and happy new year!