AbletonOSC icon indicating copy to clipboard operation
AbletonOSC copied to clipboard

Introduce missing Clip properties to run-console.py + view.py

Open esaruoho opened this issue 1 year ago • 6 comments

Hi @ideoforms Since I can't wrap my mind around the "view clip or view device on track" mode change, but you did point me to the unofficial PythonLiveAPI - I'm trying to do the lowest hanging fruit, which is this:

this PR introduces the following properties to clip.py + autocomplete in run-console.py:

has_groove
is_overdubbing
sample_length
start_time
will_record_on_start
color_index
launch_mode
launch_quantization
legato
muted
position
ram_mode
velocity_amount
warp_mode

i also added some comments to the code that might help with where it could be taken later - i.e. since some of the commented away properties actually return something that is not processed properly by run-console.py - i.e. error "Infered arg_value type is not supported" - maybe someone can take that over the finishing line.

do let me know if this type of stuff is welcome. i think the position one is amazing! warp_mode was weird tho, with number 5 shooting errors whereas 6 shoots "Complex Pro" without issues.

if this is welcome, I'll run through the rest of the functions and try and make small increment tweaks until they amount to something.

esaruoho avatar Sep 29 '24 21:09 esaruoho

added clip properties to documentation too.

esaruoho avatar Sep 29 '24 21:09 esaruoho

@ideoforms what do you think, is this good to go?

esaruoho avatar Oct 02 '24 19:10 esaruoho

@ideoforms ping - does this PR make any sense for you? it seems to me that this was a good start at adding more stuff in there, and i left the TODOs documented for someone else to pick up.

I'd love to continue working on adding more missing properties/controls for other parts of AbletonOSC - but just need your green light really.

esaruoho avatar Nov 09 '24 19:11 esaruoho

Hi @ideoforms , any take on this? I was hoping to introduce more PRs with more additions but have been waiting to see what happens with this first before putting more work in :)

esaruoho avatar Jan 27 '25 01:01 esaruoho

@ideoforms thanks! i've addressed the comments with a new commit.

if you're okay with the new commit, please let me know, and i can try and have a look at test_clip.py, but thinking about it makes my hands shake. i hope i'll find a slice of time to do that, too.

esaruoho avatar Jan 27 '25 09:01 esaruoho

Changes look great, thanks! You'll do great on the tests. Best way is to start with a really simple one, just by copying one of the existing tests (e.g. try writing a test for color_index based on the one for color), and then build from there.

ideoforms avatar Jan 27 '25 09:01 ideoforms

This PR adds a lot of useful new functionality particularly around clip operations, so in order to help clear the backlog, I'm going to merge it even though the new features don't yet have tests. These can be added later. Thanks @esaruoho!

ideoforms avatar Nov 16 '25 22:11 ideoforms