id-area-keys icon indicating copy to clipboard operation
id-area-keys copied to clipboard

Add id editor `osmAreaKeysExceptions` to the list

Open tordans opened this issue 1 year ago • 2 comments

There are a few exceptions which describe area features but are not covered by presets. They are hard coded at https://github.com/openstreetmap/iD/pull/10278/files#diff-02f586096655a2fa6acaba20cb00a885b0594767d860e7cab713bc8e9d00d95dL42-L68 ATM.

It might be worth extracting those to a shared place or maybe expand this package to hold them so all iD-like editors can use them.

The same goes for the osmRemoveLifecyclePrefix helper (https://github.com/openstreetmap/iD/pull/10278/files#diff-02f586096655a2fa6acaba20cb00a885b0594767d860e7cab713bc8e9d00d95dL78) which would also be a good addition to this package.

tordans avatar Jun 11 '24 11:06 tordans

Good suggestion to include the exceptions. I don't know whether anyone is actually using this package still, but I do want the isArea() function to return mostly correct results.

bhousel avatar Jun 15 '24 15:06 bhousel

I don't know whether anyone is actually using this package still

I only noticed it due to its use in the real-changesets-parser which part of the core of osmcha. But the Dependents view lists a few other repos and packages (with OSMCha having the most stars)

but I do want the isArea() function to return mostly correct results.

I wonder if this should be split up in a "isConsideredArea" (the part from iD) and "canBeMappedAsArea" (the part from this library which relies on the tagging schema).

tordans avatar Jun 15 '24 20:06 tordans