ShareKit Untitled

Hi there,

My fork fixes a memory leak in the OAuth helper classes, a crash when clicking the "more" button, and improves the messaging with the MBProgessHUD (and some convenience class methods in SHK.m).

It also has a bunch of other small improvements that I added for my own use and which might be useful in the main branch.

Jan 16 '11 20:01 benjaminjackson

There's some good stuff in here, but you should review it for security. I noticed right off the bat that twitter usernames/passwords are stored in NSUserDefaults, which could compromise the user's login credentials.

Mar 30 '11 06:03 alariccole

Good catch. Thanks for the heads up. Will review ASAP.

Apr 06 '11 03:04 benjaminjackson

Where did you see this? I'm not finding it.

Apr 06 '11 03:04 benjaminjackson

You know, I may have been taken aback by the simulator-only methods in ShareKit, and thought these applied to the device.

Apr 06 '11 04:04 alariccole

Yeah, I double-checked and that's all it was. Sorry for the false alarm. I do have a verified issue with MBProgressHUD not getting the proper frame, though. I sometimes find it crammed in the bottom left corner on my app which runs in landscape. Rotating the device resets its frame and causes it do display properly in the center. I can't find the right way to fix it, but I have seen it getting negative values for its x coords by placing an NSLog(@"layout x %f", indFrame.origin.x) around line 508 (end of the layoutSubviews method).

Apr 06 '11 23:04 alariccole

Found a fix. You may want to incorporate this: https://github.com/chiefy/MBProgressHUD/commit/d4fab41c429ad9333a022f3dee9609a3ba43ed57#diff-14

Apr 06 '11 23:04 alariccole

Great! Thanks for letting me know. I haven't seen this issue but will check it out.

Apr 10 '11 17:04 benjaminjackson