imagededup icon indicating copy to clipboard operation
imagededup copied to clipboard

Published 20 hours ago • verified publisher icon idealo

Fix/installation

Open tanujjain opened this issue 4 years ago • 4 comments

Running python setup.py install on the dev branch fails.

Tensorflow and numpy aren't playing well with each other. Leave tf>1.0 in setup.py with no mention of numpy (i.e., relying on tf to get numpy) leads to an error since tf 2.4.1 gets installed along with numpy 1.20.1 (due to pip resolver algo), but tf 2.4.1 needs numpy=~1.9.2. Explicitly mentioning numpy <1.20.0, makes the installation work. Additionally, newer versions of numpy (1.20.1), scipy (1.6 onwards) and matplotlib do not support python 3.6 anymore. The changes proposed in this PR will also work from Python 3.7 onwards.

tanujjain avatar Mar 16 '21 10:03 tanujjain

Hey looking good. Overall I believe that setting tf>1.0 is not the right approach. TensorFlow has many upward/downward compatibility problems. Could imagine that tf >= 3.0 will break everything but then we can change it accordingly to 1.0 < tf =<2.0.

datitran avatar Apr 05 '21 13:04 datitran

@datitran We would no longer be able to support py3.6 after this fix is shipped. Just want to confirm if you're onboard with that?

tanujjain avatar Apr 06 '21 07:04 tanujjain

I think that should be okay until we find a long-term fix. We should find a better solution on this.

datitran avatar Apr 09 '21 09:04 datitran

@tanujjain Is this going to be merged with main any time soon?

collinarnett avatar Aug 17 '21 23:08 collinarnett