Iddan Aaronsohn comments

Results 243 comments of


                                            Iddan Aaronsohn

Testing nexus resolvers

Since nexus uses Apollo Server you can use Apollo Server testing. See [Integration testing](https://www.apollographql.com/docs/apollo-server/testing/testing/). A tutorial can be added that follow Apollo tutorial but uses Nexus schema

Use semicolon separator for multiple statements with same subject

Another option would be preserving the syntax variant in the AST

Create a "One Dark+" theme

Suggestions: - highlight all variables in red - highlight all function tokens (even when not invoked) in blue - highlight all class tokens (even when not invoked) in Yellow

Scroll limitations in the log table

Should add inner scroll

Scroll limitations in the log table

Maybe move to horizontal view as most POST requests will have long body to read

Informing about React.lazy()

True, yet for non SSR use and future use when it will be supported it should be informed.

Menu Position Right RTL

This should be changed to: ```javascript get boundryStyle() { const { menuPosition } = this.props if (I18nManager.isRTL && menuPosition === 'right') { return { right: this.state.width - this.state.openMenuOffset } }...

Menu Position Right RTL

You should probably open a PR

Deploy Fails when using the action but not when using the CLI

Hey, the `name` is `*****-***-cloud-function-dev` and the `entry_point` is `app`. If it helps, I can send you the details in a non-public channel.

Deploy Fails when using the action but not when using the CLI

This is the step in the GitHub Action: ```yaml - name: Deploy to GCF uses: google-github-actions/[email protected] with: min_instances: 4 runtime: nodejs12 name: **** entry_point: **** timeout: 540s env_vars: **** deploy_timeout:...