bashlex icon indicating copy to clipboard operation
bashlex copied to clipboard

Published 20 hours ago • verified publisher icon idank

Refactoring class names

Open tusharmakkar08 opened this issue 8 years ago • 2 comments

I was just grazing through the code and found that lot of class name in ast.py is in small letters. In PEP8, class names have CapWords. Just wanted to ask if this was intentional. If not, I can submit a PR for the fix.

tusharmakkar08 avatar Dec 12 '16 13:12 tusharmakkar08

It's a style I got used to when working on Mercurial (another Python project). I don't think I've tried running the code against a linter, there are probably many more "violations".

I'm not opposed to fixing these but in particular function/class names are tricky because we'd have to alias the old names to stay backward compatible, all in all not worth it in my opinion.

idank avatar Dec 12 '16 14:12 idank

Refactoring tools do help a lot in these cases. I'll try doing them and depending on the ROI create a PR.

Thanks.

tusharmakkar08 avatar Dec 13 '16 05:12 tusharmakkar08