gistio icon indicating copy to clipboard operation
gistio copied to clipboard

changed url matching to word characters [A-Za-z0-9]

Open ghost opened this issue 10 years ago • 20 comments

Gist ID's now include more then characters ([A-Za-z]), but also digits ([A-Za-z0-9]).

ghost avatar May 07 '14 00:05 ghost

@MarkKettner are they fully alphanumeric or is it hex? Have you seen anything outside of [A-Fa-f0-9]?

idan avatar May 07 '14 17:05 idan

@idan I just created a few to test and you appear correct, they are all hexadecimal digits

ghost avatar May 07 '14 18:05 ghost

Hmm, okay—just tried, and it looks like github's actual change is to make public gist identifiers the same format as private ones: 20 char hex strings. This is problematic in that there's no way to differentiate between the public gists (which we support) and the private ones (which would require some work to support) at the URL level.

idan avatar May 07 '14 18:05 idan

@idan Can you go ahead and still merge this for now because as of now it's no longer working with any new gists.

BukhariH avatar May 21 '14 12:05 BukhariH

+1

causal-agent avatar May 24 '14 17:05 causal-agent

Yup. New gists no longer work :-(

shapeshed avatar May 27 '14 15:05 shapeshed

:+1:

antoinelyset avatar May 29 '14 15:05 antoinelyset

:+1:

yunga avatar Jun 02 '14 07:06 yunga

+1

miniops avatar Jun 16 '14 06:06 miniops

+1

clrh avatar Jun 20 '14 14:06 clrh

please merge this

szexigexi avatar Jun 20 '14 15:06 szexigexi

gist.io hasn't been working in a while. Is this project abandoned? I really want to use the tool.

mikejholly avatar Jun 25 '14 13:06 mikejholly

The maintainer:

image

:disappointed:

causal-agent avatar Jun 25 '14 14:06 causal-agent

@programble You could try to reach him at: https://twitter.com/idangazit

BukhariH avatar Jun 25 '14 16:06 BukhariH

@BukhariH I've emailed him offering to take over maintenance of this project.

causal-agent avatar Jun 25 '14 17:06 causal-agent

@programble Nice! Good Luck!

BukhariH avatar Jun 25 '14 17:06 BukhariH

I'm not sure if @idan is using this repo anymore. There appears to be a Flask version of this site called gistio.py in the same repo which contains an extra view at /int:id/content which appears to be live http://gist.io/3135754/content. It is also referenced in the Procfile

The Django site in this repo doesn't contain a view at that path and I tried running the Flask version locally but the templates are still in Django format as opposed to Jinga2. So theres quite a few template syntax errors. I doubt this version of the codebase is the one that is deployed.

nwjlyons avatar Aug 30 '14 14:08 nwjlyons

It appears that the Gist API only returns content for public gists "with a token", although I might be misunderstanding.

Even so, the API also returns "public": true, or "public": false, so surely the easiest way to implement this is to pick up @MarkKettner's update, and add a test for the "public" value to prevent private gists from being gistio'ed.

Gist.io is too good to go away! :(

pretty

dajare avatar Sep 25 '14 09:09 dajare

@mikejholly @programble @dajare I've forked gist.io to draft.sx and have already implemented support for current public and private gist urls (as far as I've tested). I'd welcome other contributors :smile:

x3ro avatar Oct 07 '14 23:10 x3ro

:+1:

jeremejazz avatar Dec 28 '17 08:12 jeremejazz