epio_skel
epio_skel copied to clipboard
idan
making sure that media on the development environment is not served from outside the environment.
~ settings: use epio settings to set correct media paths; bring development media path inside app directory. ~ structure: auto create media, static and static_root using stub .gitignores ~ fabfile: use --noinput on collectstatic to remove prompt ~ fabfile: use file to make sure fabfile can be called from anywhere and still initiate epio client from correct directory.
I like some of the practical bits in this pull request, but there are parts I don't grok. Check out the above comments on lines of code.
Added comments above for each of the changes.
Overall I like the changes, save those I've explicitly -1'd. Once everything is sorted out with the various comments I've made, this will get merged -- thank you for your work!
While you're at it, add an Authors section at the bottom of readme with your name in it.
You've kicked the ball this far; I don't want to appear unappreciative. If you like, I can pull these commits to a branch, make the desired cleanup, and merge it myself.
if you'd like to cherry pick code, go ahead. Otherwise i can fix it up and you can pull. your choice.
Well, gonna pull an executive lazy and let you make the changes; thanks again for your work. :)