idaholab
Submodule update
This PR was generated by a script. Interesting that it is changing files other than submodules. I'll look into it.
This PR was generated by a script. Interesting that it is changing files other than submodules. I'll look into it.
I have updated the script to resolve the issue.
Job VTB Documentation, step Sync Docs on c48ba02 wanted to post the following:
View the site here
This comment will be updated on new commits.
I think we need pronghorn to have an updated moose submodule here, since subchannel tesrs are now tied to moose
Any idea when we may see these submodule updates go in? A moose submodule update in BISON a couple weeks ago (that included a libmesh update) started causing a VTB case to behave differently on our VTB testing and therefore our devel testing is failing. I believe the fix should just be the submodule update here. If a further regold is necessary I can push a change but didn't want to push any submodule update to conflict with this PR.
I believe the fix should just be the submodule update here.
this cant be the fix, if the input now diffs it will diff here too if we update to a devel bison. We just dont see it because we are updating to a new version of master
If a further regold is necessary I can push a change but didn't want to push any submodule update to conflict with this PR
Dont worry about that, this PR still has some failures and rebasing can be done when addressing any failure.
I believe the fix should just be the submodule update here.
this cant be the fix, if the input now diffs it will diff here too if we update to a devel bison. We just dont see it because we are updating to a new version of master
If a further regold is necessary I can push a change but didn't want to push any submodule update to conflict with this PR
Dont worry about that, this PR still has some failures and rebasing can be done when addressing any failure.
I think @elementx54's PR here: https://github.com/idaholab/virtual_test_bed/pull/551 which does other regolding has the necessary test regold that will start diffing with the submodule update. Currently, that test fails when he regolds because the submodule updates have not made their way in. I'll have him add a BISON submodule update to that PR.
@GiudGiud, this is ready. Failure in griffin devel is likely unrelated and will be further investigated in #561.
Awesome thanks for taking care of this!
If the script you used is the one checked in and you improved it let's update it online too btw