virtual_test_bed icon indicating copy to clipboard operation
virtual_test_bed copied to clipboard

KRUSTY Multiphysics Model

Open aabdelhameedd opened this issue 1 year ago • 8 comments

This PR is related to issue #394

aabdelhameedd avatar Jul 03 '24 17:07 aabdelhameedd

Job VTB Documentation on fef95d6 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Jul 06 '24 03:07 moosebuild

@GiudGiud Thanks for the review. I think we resolved all the comments. It should be ready for another round of review.

I added some syntax check tests and mesh gen tests. Not sure if we want regression tests as these are kind of heavy.

miaoyinb avatar Jul 10 '24 20:07 miaoyinb

can you run a single timestep for the BISON case? and what about an eigenvalue calculation without multiphysics for the Griffin one? how expensive would each of those be? we have access to a beefier machine for Griffin now, within reason we can make some larger cases work

GiudGiud avatar Jul 10 '24 21:07 GiudGiud

The Griffin neutronic alone calculation on sawtooth is roughly about 12 minutes with 640 CPUs if using NA=3, SN35. For NA=1 and SN13, the run time can be 20 times faster. Yan

From: Guillaume Giudicelli @.> Sent: Wednesday, July 10, 2024 4:18 PM To: idaholab/virtual_test_bed @.> Cc: Cao, Yan @.>; Assign @.> Subject: Re: [idaholab/virtual_test_bed] KRUSTY Multiphysics Model (PR #404)

can you run a single timestep for the BISON case? and what about an eigenvalue calculation without multiphysics for the Griffin one? how expensive would each of those be? we have access to a beefier machine for Griffin now, within reason we ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd

can you run a single timestep for the BISON case? and what about an eigenvalue calculation without multiphysics for the Griffin one? how expensive would each of those be? we have access to a beefier machine for Griffin now, within reason we can make some larger cases work

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/idaholab/virtual_test_bed/pull/404*issuecomment-2221496270__;Iw!!G_uCfscf7eWS!dpTHmxfrOxit8_Zfl7FMbY_AcgW47jq_7pd5L-eDIk2eqAzok3xEPVX11Lq3AxSKcGAd_vr7ceYv7hsGrdL91w$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/BJUPMMEVCCIEDORCLZSXJKTZLWQH3AVCNFSM6AAAAABKKBIQO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRGQ4TMMRXGA__;!!G_uCfscf7eWS!dpTHmxfrOxit8_Zfl7FMbY_AcgW47jq_7pd5L-eDIk2eqAzok3xEPVX11Lq3AxSKcGAd_vr7ceYv7hsPQQen5w$. You are receiving this because you were assigned.Message ID: @.@.>>

ycao-anl avatar Jul 10 '24 21:07 ycao-anl

For NA=1 and SN13, the run time can be 20 times faster.

that seems workable. The tests can modify the input through cli_args so we can afford to run that for regression

GiudGiud avatar Jul 10 '24 21:07 GiudGiud

Regression cases added.

miaoyinb avatar Jul 11 '24 18:07 miaoyinb

@GiudGiud just a friendly reminder that this PR is ready for another round of review. Thanks.

miaoyinb avatar Jul 15 '24 17:07 miaoyinb

Hello!

I'll get to it once our giant submodule update PR makes it through. Thansk for reaching it out

GiudGiud avatar Jul 15 '24 17:07 GiudGiud

@GiudGiud Just a friendly reminder that this is still pending review. Thanks in advance.

miaoyinb avatar Aug 12 '24 16:08 miaoyinb

will do! thanks for the reminder.

GiudGiud avatar Aug 12 '24 17:08 GiudGiud

to reduce the picture size you must remove it from the commit that introduced it. Otherwise it does not change anything with regards to the repository size

GiudGiud avatar Aug 15 '24 00:08 GiudGiud

to reduce the picture size you must remove it from the commit that introduced it. Otherwise it does not change anything with regards to the repository size

Will do. I am working on the other comments and will do a rebase once everything looks fine.

miaoyinb avatar Aug 15 '24 00:08 miaoyinb

Job MOOSE on b995bbd : invalidated by @miaoyinb

moosebuild avatar Aug 15 '24 15:08 moosebuild

It seems that something is wrong with CIVET.

miaoyinb avatar Aug 15 '24 15:08 miaoyinb

looks like it does not converge on HPC for me. We could be getting unlucky, what is the exact configuration you ran? 15 nodes * 40 procs?

alternatively we should change BISON to not error but rather to use the solutionInvalidInterface here

log.txt

GiudGiud avatar Aug 19 '24 15:08 GiudGiud

I used one sawtooth node (48 cores) for the short testing problem here.

For full problem, I use 10 nodes * 24 cores on sawtooth for SN(2,3) NA=3. I will double check the input...

miaoyinb avatar Aug 19 '24 15:08 miaoyinb

for the input as is (not changing the azimuthal, so SN 3,5,3) what did you use?

GiudGiud avatar Aug 19 '24 16:08 GiudGiud

I used 2 3 3

miaoyinb avatar Aug 19 '24 16:08 miaoyinb

I imagine 2,3,3 works fine?

@aabdelhameedd what was the computational resources configuration to run the input as it is currently ?

GiudGiud avatar Aug 19 '24 16:08 GiudGiud

I think we only use 3 5 3 for neutronics only. How many nodes did you use? @ycao-anl

miaoyinb avatar Aug 19 '24 16:08 miaoyinb

I used 640 CPUs.

Yan

From: Yinbin Miao @.> Sent: Monday, August 19, 2024 11:44 AM To: idaholab/virtual_test_bed @.> Cc: Cao, Yan @.>; Mention @.> Subject: Re: [idaholab/virtual_test_bed] KRUSTY Multiphysics Model (PR #404)

I think we only use 3 5 3 for neutronics only. How many nodes did you use? @ycao-anl — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message ID: <idaholab/virtual_test_bed/pull/404/c2296997762@ github. com> ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd

I think we only use 3 5 3 for neutronics only. How many nodes did you use? @ycao-anlhttps://urldefense.us/v3/__https:/github.com/ycao-anl__;!!G_uCfscf7eWS!ZgqJOEp9MbrDFJy7F7-aa7SGsg63cQHj_tI4x_SqS511TZ8O44QVRCnbmYnRvVkoivz8luUi95s_R03k8_ldiw$

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/idaholab/virtual_test_bed/pull/404*issuecomment-2296997762__;Iw!!G_uCfscf7eWS!ZgqJOEp9MbrDFJy7F7-aa7SGsg63cQHj_tI4x_SqS511TZ8O44QVRCnbmYnRvVkoivz8luUi95s_R03JxQxXvQ$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/BJUPMMEZ65UQ2KJZHJXPWSLZSIOELAVCNFSM6AAAAABKKBIQO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWHE4TONZWGI__;!!G_uCfscf7eWS!ZgqJOEp9MbrDFJy7F7-aa7SGsg63cQHj_tI4x_SqS511TZ8O44QVRCnbmYnRvVkoivz8luUi95s_R02H0-IR2w$. You are receiving this because you were mentioned.Message ID: @.@.>>

ycao-anl avatar Aug 19 '24 16:08 ycao-anl

how did you do 640 on sawtooth? 16 nodes with 40 cpus each? asking because sawtooth has 48 cpus per node

GiudGiud avatar Aug 19 '24 16:08 GiudGiud

Ah, for the multiphysics simulations, the power needs to be reduced as the model is for the warm critical tests without heat pipe heat removal. I will fix it soon. We use 0.01 W for steady state as the power only rises to ~900W during reactivity insertion transient.

miaoyinb avatar Aug 19 '24 17:08 miaoyinb

Yes, I used 40 cpus and 16 nodes.

From: Guillaume Giudicelli @.> Sent: Monday, August 19, 2024 11:58 AM To: idaholab/virtual_test_bed @.> Cc: Cao, Yan @.>; Mention @.> Subject: Re: [idaholab/virtual_test_bed] KRUSTY Multiphysics Model (PR #404)

how did you do 640 on sawtooth? 16 nodes with 40 cpus each? asking because sawtooth has 48 cpus per node — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message ID:  ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd

how did you do 640 on sawtooth? 16 nodes with 40 cpus each? asking because sawtooth has 48 cpus per node

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/idaholab/virtual_test_bed/pull/404*issuecomment-2297022681__;Iw!!G_uCfscf7eWS!b5YoHGT_FJQnC-dORaYKOLBcLDlUsXN8yubFRK9C8w3z0RrBwoghFk4TtxZ4Em1DFrQBr0kiyB66E53tHPIxQw$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/BJUPMMDKHUI6WHO7OQGD6NTZSIPZ5AVCNFSM6AAAAABKKBIQO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGAZDENRYGE__;!!G_uCfscf7eWS!b5YoHGT_FJQnC-dORaYKOLBcLDlUsXN8yubFRK9C8w3z0RrBwoghFk4TtxZ4Em1DFrQBr0kiyB66E533XIpJvg$. You are receiving this because you were mentioned.Message ID: @.@.>>

ycao-anl avatar Aug 19 '24 17:08 ycao-anl

Sounds good. Thanks @ycao-anl Thanks @miaoyinb we should be able to roll this out soon then! VTB testing is back on now too

GiudGiud avatar Aug 19 '24 17:08 GiudGiud

I'll take it from here @miaoyinb I was waiting for the recipes to update. I think you merged it right on time though

GiudGiud avatar Aug 19 '24 21:08 GiudGiud

Test failures are unrelated, on other modles, and being addressed in current maintenance operations

GiudGiud avatar Aug 20 '24 00:08 GiudGiud

Cardinal failure unrelated, DW recipe crashed but passed earlier

GiudGiud avatar Aug 20 '24 16:08 GiudGiud

Thanks for the contribution @aabdelhameedd @ycao-anl @miaoyinb !

GiudGiud avatar Aug 20 '24 16:08 GiudGiud