raven icon indicating copy to clipboard operation
raven copied to clipboard

[DEFECT] Undefined or incorrectly defined constrain functions are not checked until second iteration of optimization.

Open cbroman-usnctech opened this issue 2 years ago • 1 comments

Thank you for the defect report

Defect Description

If an optimizer is created with a constrain function (Implicit or explicit). RAVEN does not first check whether or not the constrain function exists or if it is implemented correctly prior to running a routine. After one full iteration of the optimization routine is complete, then RAVEN does properly catch the error. It would be beneficial to catch such errors up-front rather than waiting for one complete optimization set.

Steps to Reproduce

Un defined or incorrectly defined constrain function.

Expected Behavior

An error to be thrown if constrain function is not defined or incorrectly implemented.

Screenshots and Input Files

No response

OS

Linux

OS Version

Ubuntu-20.04

Dependency Manager

PIP

For Change Control Board: Issue Review

  • [ ] Is it tagged with a type: defect or task?
  • [ ] Is it tagged with a priority: critical, normal or minor?
  • [ ] If it will impact requirements or requirements tests, is it tagged with requirements?
  • [ ] If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • [ ] Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

  • [ ] If the issue is a defect, is the defect fixed?
  • [ ] If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • [ ] If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • [ ] If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • [ ] If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

cbroman-usnctech avatar Feb 03 '23 19:02 cbroman-usnctech

@mandd @Jimmy-INL @JunyungKim This is another related issue, please make a plan and address it in the near future.

wangcj05 avatar Feb 20 '23 17:02 wangcj05