raven icon indicating copy to clipboard operation
raven copied to clipboard

Mattdon/new melcor interface

Open mandd opened this issue 2 years ago • 9 comments


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #2125

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • [ ] 1. Review all computer code.
  • [ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • [ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • [ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • [ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in <RunInfo> XML block, the node <internalParallel> to True.
  • [ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • [ ] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • [ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • [ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

mandd avatar Nov 17 '22 22:11 mandd

Job Mingw Test on 3eb7f67 : invalidated by @joshua-cogliati-inl

restarted civet

moosebuild avatar Feb 22 '23 15:02 moosebuild

Job Precheck on d8c1ae7 : invalidated by @aalfonsi

moosebuild avatar May 26 '23 19:05 moosebuild

Job Precheck on d8c1ae7 : invalidated by @aalfonsi

@mandd @aalfonsi FYI, pre-check failed due to hpcgithub issue. This may be resolved until next Tuesday.

wangcj05 avatar May 26 '23 19:05 wangcj05

Job Precheck on d8c1ae7 : invalidated by @aalfonsi

moosebuild avatar May 27 '23 20:05 moosebuild

@wangcj05 : this PR is good to be reviewed

mandd avatar Jun 02 '23 22:06 mandd

Job Mingw Test on 851e8df : invalidated by @mandd

moosebuild avatar Jun 03 '23 20:06 moosebuild

Job Test qsubs sawtooth on 851e8df : invalidated by @mandd

moosebuild avatar Jun 03 '23 20:06 moosebuild

@mandd Could you create an issue for this PR? In addition, could you update the description for this PR? I will review it this week.

wangcj05 avatar Jun 05 '23 14:06 wangcj05

This PR is good to go I think

mandd avatar Sep 22 '23 21:09 mandd