raven Allow OS specific gold files

Allow OS specific gold files

Open dgarrett622 opened this issue 2 years ago • 16 comments

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Addresses #1900

What are the significant changes in functionality due to this change request?

For testing, OS specific gold files may be specified using parameters windows_gold, mac_gold, or linux_gold as seen in the test file tests/framework/PostProcessors/LimitSurface/tests under ./testLimitSurfaceIntegralPPWithBoundingError

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in <RunInfo> XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Jul 22 '22 18:07 dgarrett622

I'm not sure where the civet testing suite interface went. @joshua-cogliati-inl does this have something to do with how CIVET was down earlier this week?

Jul 27 '22 15:07 dylanjm

Changes appear good to me. I wonder if there is a way that we can just name the gold file we want to compare to instead of having three separate input parameters?

There is a "gold_files" input parameter where you can name the gold file you want to compare to, but if the results are OS dependent, there isn't currently a way to specify them. I suppose if a naming convention for gold files were to be imposed that included OS information in the name of the gold file, this would solve that issue and a different change would be necessary.

Jul 27 '22 16:07 dgarrett622

There is a "gold_files" input parameter where you can name the gold file you want to compare to, but if the results are OS dependent, there isn't currently a way to specify them. I suppose if a naming convention for gold files were to be imposed that included OS information in the name of the gold file, this would solve that issue and a different change would be necessary.

Ah okay, that makes sense to me. This seems like best solution then.

@dgarrett622 maybe pushing again will trigger CIVET to run?

Jul 27 '22 16:07 dylanjm

@dgarrett622 Looks like we don't allow snake case get past the pylint check despite the whole rook codebase using snake case...🤦

Jul 27 '22 20:07 dylanjm

@dylanjm I think I mixed upper case and lower case in the variable names, which doesn't seem to be allowed with snake_case. I switched it to all lower case and split up some lines, maybe that will work 🤷‍♂️

Jul 27 '22 20:07 dgarrett622

Job Mingw Test on 5fe19b8 : invalidated by @dgarrett622