raven icon indicating copy to clipboard operation
raven copied to clipboard

Update Basic Statistics

Open joshua-cogliati-inl opened this issue 3 years ago • 9 comments


Pull Request Description

What issue does this change request address?

Closes #1653

What are the significant changes in functionality due to this change request?

This updates the BasicStatistics PP to use the new PP-ready interface which standardizes the API and hence BasicStatistics can be used by other PPs such as validation PPs.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • [ ] 1. Review all computer code.
  • [ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • [ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • [ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • [ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in <RunInfo> XML block, the node <internalParallel> to True.
  • [ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • [ ] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • [ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • [ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

joshua-cogliati-inl avatar Nov 23 '21 23:11 joshua-cogliati-inl

Job Test Ubuntu 18 PIP on bbef143 : invalidated by @joshua-cogliati-inl

restarted civet

moosebuild avatar Nov 24 '21 18:11 moosebuild

Job Test Ubuntu 18 PIP on bbef143 : invalidated by @Jimmy-INL

moosebuild avatar Nov 24 '21 19:11 moosebuild

Job Test qsubs falcon on bbef143 : invalidated by @joshua-cogliati-inl

Diff tests/cluster_tests/test_mpiqsub_limitnode

moosebuild avatar Nov 24 '21 19:11 moosebuild

Job Test Ubuntu 18-2 Python 3 on bbef143 : invalidated by @joshua-cogliati-inl

restarted civet

moosebuild avatar Nov 24 '21 19:11 moosebuild

Job Test qsubs falcon on bbef143 : invalidated by @joshua-cogliati-inl

Failed Diff tests/cluster_tests/RavenRunsRaven/Code Diff tests/cluster_tests/test_mpiqsub_limitnode

moosebuild avatar Nov 29 '21 14:11 moosebuild

Job Test mac on 9abe64f : invalidated by @joshua-cogliati-inl

testing civet

moosebuild avatar Dec 02 '21 19:12 moosebuild

@joshua-cogliati-inl Is this going to be merged soon? I am planning to address issue https://github.com/idaholab/raven/issues/1923 soon and if this is merged soon I will wait for this new restructuring to be ready before workin on issue #1923

aalfonsi avatar Sep 15 '22 04:09 aalfonsi

@aalfonsi I believe this PR has been already integrated in PR #1847. @Jimmy-INL Do you have estimate for PR#1847? I have already provided my comments for that PR.

wangcj05 avatar Sep 15 '22 04:09 wangcj05

Yes I think so


From: Congjian Wang - INL @.> Sent: Wednesday, September 14, 2022 10:19:38 PM To: idaholab/raven @.> Cc: Mohammad G. Abdo @.>; Mention @.> Subject: [EXTERNAL] Re: [idaholab/raven] Update Basic Statistics (PR #1721)

@aalfonsihttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faalfonsi&data=05%7C01%7Cmohammad.abdo%40inl.gov%7C777932659f744b5f2cd408da96d18167%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637988123817452688%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JqIj%2B52%2BR%2B90AtCPHc2Yqv5eWC7mO0ENfKaVZIiKpYc%3D&reserved=0 I believe this PR has been already integrated in PR #1847https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fidaholab%2Fraven%2Fpull%2F1847&data=05%7C01%7Cmohammad.abdo%40inl.gov%7C777932659f744b5f2cd408da96d18167%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637988123817452688%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5SpeEgZSmNbOHbslkdHE%2FyINKcN9ZTp%2F2bZ3PjbfIPM%3D&reserved=0. @Jimmy-INLhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJimmy-INL&data=05%7C01%7Cmohammad.abdo%40inl.gov%7C777932659f744b5f2cd408da96d18167%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637988123817452688%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gCqm0x6042XvvfSjX0vrO8RjkcbLejjMfkiXQWOoznY%3D&reserved=0 Do you have estimate for PR#1847? I have already provided my comments for that PR.

— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fidaholab%2Fraven%2Fpull%2F1721%23issuecomment-1247562568&data=05%7C01%7Cmohammad.abdo%40inl.gov%7C777932659f744b5f2cd408da96d18167%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637988123817452688%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1I3YgC4ccFkQbt8CoNx%2BeTLr%2BzriefpktGQ6F%2FPwFKw%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMP5ECXFC3ZB5TEGLJOCF3DV6KPVVANCNFSM5IUVKWYQ&data=05%7C01%7Cmohammad.abdo%40inl.gov%7C777932659f744b5f2cd408da96d18167%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637988123817452688%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Q9uqm2foZgsXB6deX75B78JKA7TzlF6lyX0p%2FmPbnKQ%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

Jimmy-INL avatar Sep 15 '22 04:09 Jimmy-INL

I guess this work has been integrated in PR #1847

wangcj05 avatar Nov 16 '22 23:11 wangcj05