raven
raven copied to clipboard
idaholab
ROM Train on DataSet
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Addresses #731 for ROMs (not PP).
What are the significant changes in functionality due to this change request?
Allows option to pass training data sets directly to ROM SupervisedLearning algorithms rather than converting everything to dictionaries.
A flag is used to allow the SVL to self-identify whether it needs legacy training (dictionaries) or can handle training via DataSet.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
- [ ] 1. Review all computer code.
- [ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
- [ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
- [ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
- [ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in <RunInfo> XML block, the node
<internalParallel>to True. - [ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
- [ ] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
- [ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
- [ ] 9. If any test used as a basis for documentation examples (currently found in
raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.
@PaulTalbot-INL @wangcj05 @mandd guys, is this going to happen anytime soon?
guys, is this going to happen anytime soon?
If I recall correctly, the DMDc merge introduced some conflicting mechanics as well as code conflicts, so I haven't returned to try and finish it off. If you need it for something, I can try and fit it in (you know, late evening or early mornings)
guys, is this going to happen anytime soon?
If I recall correctly, the DMDc merge introduced some conflicting mechanics as well as code conflicts, so I haven't returned to try and finish it off. If you need it for something, I can try and fit it in (you know, late evening or early mornings)
oh got it. Do you have an ETA more and less?
You know how it is, as soon as someone needs it, it will become a priority. I don't foresee needing it until near end of this FY, for my stuff, if not early next year.
You know how it is, as soon as someone needs it, it will become a priority. I don't foresee needing it until near end of this FY, for my stuff, if not early next year. Okay. Slow pace at the lab it seems. eheheh I am kidding. Thanks for the update ;)
I believe all of the critical changes have been ported to other PRs and merged. @dylanjm can you confirm? I can close this if there's nothing else of value to scavenge from it.
@PaulTalbot-INL Yes, I was able to grab the custom sampler stuff in another PR. I think Yeni has a few changes in her RAVEN which she'll push as a PR eventually. Unless there are other changes, I think the majority of what we needed here has been integrated.
