raven icon indicating copy to clipboard operation
raven copied to clipboard

[DEFECT] Working directory relative to location of input file

Open aalfonsi opened this issue 2 years ago • 3 comments


Defect Description

Describe the defect

What did you expect to see happen?

follow up of conversation https://github.com/idaholab/raven/pull/1677#discussion_r732397201

The working directory, if not specified via abs path, should always refer to the location of the input file

What did you see instead?

a workingDir is generated if the input file is invoked from a different directory. This causes that the external model must reside in this "newly generated working dir" but the results are stored in the working director at the location of the input file

Do you have a suggested fix for the development team?

Describe how to Reproduce Steps to reproduce the behavior: 1. 2. 3. 4.

Screenshots and Input Files Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • [ ] 1. Is it tagged with a type: defect or task?
  • [ ] 2. Is it tagged with a priority: critical, normal or minor?
  • [ ] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • [ ] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • [ ] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • [ ] 1. If the issue is a defect, is the defect fixed?
  • [ ] 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • [ ] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • [ ] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • [ ] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

aalfonsi avatar Oct 20 '21 22:10 aalfonsi

similar issue: #65 #86

wangcj05 avatar Jun 22 '22 19:06 wangcj05

@Jimmy-INL Here is an example "raven/tests/framework/test_iostep_load.xml", if you run in the folder "raven/tests/framework/", the test will run, but if you run it in folder "raven/tests/", it will fail with the following error: image

Basically, there is a path issue for the files provided by Files node.

wangcj05 avatar Jun 28 '22 19:06 wangcj05

@wangcj05 If I understand this issue correctly #1870 solves this. Also #1033 is a related issue I believe.

dylanjm avatar Jun 28 '22 19:06 dylanjm

checklist is good.

wangcj05 avatar Nov 17 '22 15:11 wangcj05