raven
raven copied to clipboard
WIP: Tanaya/umbrella
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
WIP: UMBRELLA SAMPLING
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
- [ ] 1. Review all computer code.
- [ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
- [ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
- [ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
- [ ] 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in <RunInfo> XML block, the node
<internalParallel>to True. - [ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
- [ ] 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
- [ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
- [ ] 9. If any test used as a basis for documentation examples (currently found in
raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.
@wangcj05 @PaulTalbot-INL @Jimmy-INL @dylanjm @mandd @joshua-cogliati-inl do you want me to try to address the comments or you guys are taking care of this (since part of the IES collaboration with GWU)?
Hi @aalfonsi, @nickblackmore is the student at GWU working on this contract activity, so I think he'll be working on addressing comments. Certainly if there's something of particular note that you're interested in feel free to drop a note!
Hi @aalfonsi, @nickblackmore is the student at GWU working on this contract activity, so I think he'll be working on addressing comments. Certainly if there's something of particular note that you're interested in feel free to drop a note! @PaulTalbot-INL great.... I am just trying to get rid of all my old branches and realized this PR is still pending... @nickblackmore let me know when and if I can delete the branch (or if you need anything from me for this PR)
@aalfonsi Hi, I think that I just need to resolve the conflicts-- I addressed the other requested changes. I've been working on another aspect of the project lately, but I can clean this up in the next couple of days.
Hi @PaulTalbot-INL @nickblackmore, do you have plan to finish this PR?
@PaulTalbot-INL @nickblackmore @wangcj05 Is this going to be finalized? As mentioned in January 2022 I am trying to delete/clean up all my old branches. Thanks.
@PaulTalbot-INL @nickblackmore @wangcj05 Closing this. It is clearly inactive since Jan 2021