idaholab
Template jsonfilereader
Reason
Only Real data type currently supported when reading from JSON file with JSONFileReader UO.
Design
Changed getter functions to use templates.
Impact
Will change existing API's in that the data type will need to be specified. Not sure how many downstream apps this will break. The original getters could probably be restored if necessary.
Note I don't have much experience with templated functions in C++ and had to implement the function source in the header files to get things to link properly. If there is a better way then let me know. Also I updated unit tests but don't know how to build and run them.
closes #28850
Job Precheck, step Clang format on e7e9e33 wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/28886/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format b3924ece4ed556a7ca9811a6e046eb5c4503df72
Job Documentation, step Docs: sync website on acd2f4b wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage, step Generate coverage on 4ded675 wanted to post the following:
Framework coverage
| b3924e | #28886 4ded67 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.05% | 85.05% | +0.00% | 94.87% | |
| Hits | 106298 | 106294 | -4 | 37 | |
| Misses | 18691 | 18687 | -4 | 2 | |
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
