moose icon indicating copy to clipboard operation
moose copied to clipboard

Add a versatile nodeset generator

Open GiudGiud opened this issue 1 year ago • 3 comments

closes https://github.com/idaholab/moose/issues/5895 refs https://github.com/idaholab/moose/issues/28881

To get around difficulties reported in #28869 using the Gmsh reader. This is not the best motivation, but I can see this being useful regardless

GiudGiud avatar Oct 17 '24 14:10 GiudGiud

Job Documentation, step Docs: sync website on 28b6fa1 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Oct 17 '24 23:10 moosebuild

Job Coverage, step Generate coverage on 28b6fa1 wanted to post the following:

Framework coverage

c80f51 #28873 28b6fa
Total Total +/- New
Rate 85.08% 85.09% +0.02% 96.23%
Hits 106568 106720 +152 153
Misses 18695 18696 +1 6

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

moosebuild avatar Oct 18 '24 00:10 moosebuild

@pbehne would you have time to review? This is very close to what you did for sidesets

GiudGiud avatar Oct 23 '24 07:10 GiudGiud

@pbehne would you have time to review? This is very close to what you did for sidesets

I'll take a look in the coming week!

pbehne avatar Oct 24 '24 17:10 pbehne

Starting on this now.

pbehne avatar Oct 29 '24 14:10 pbehne

thanks! @roystgnr @lindsayad for the ccb review?

GiudGiud avatar Oct 31 '24 15:10 GiudGiud

or @cticenhour if you want newsletter content 📰

GiudGiud avatar Oct 31 '24 15:10 GiudGiud

Test failures are unrelated.

Thanks for the reviews!

GiudGiud avatar Nov 01 '24 22:11 GiudGiud