moose icon indicating copy to clipboard operation
moose copied to clipboard

Finish up a variety of modules' SQA missing items to be able to enforce checks

Open GiudGiud opened this issue 1 year ago • 3 comments

refs #15968

I noticed the number of SQA warnings was actually going up rather than down. Once the checks are enforced as errors and not warnings, this wont happen anymore. This PR enforces:

  • 22 more items from warnings to errors across all modules
  • peridynamics & contact with no more warnings

GiudGiud avatar Aug 24 '24 22:08 GiudGiud

Job Documentation on ec528c3 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Aug 25 '24 21:08 moosebuild

Job Coverage on ec528c3 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Phase field

45baf0 #28464 ec528c
Total Total +/- New
Rate 86.00% 86.00% +0.00% 92.31%
Hits 13659 13679 +20 24
Misses 2224 2227 +3 2

Diff coverage report

Full coverage report

Solid mechanics

45baf0 #28464 ec528c
Total Total +/- New
Rate 84.92% 84.92% -0.00% 83.33%
Hits 28037 28047 +10 10
Misses 4977 4979 +2 2

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • solid_mechanics new line coverage rate 83.33% is less than the suggested 90.0%

This comment will be updated on new commits.

moosebuild avatar Aug 26 '24 01:08 moosebuild

I can work on this review today a bit and hopefully finalize tomorrow.

cticenhour avatar Aug 27 '24 19:08 cticenhour

interface got buggy but this was merged, then closed to attempt a "refresh" with close/reopen as the interface was frozen on "attempting to determine if PR can be merged"

GiudGiud avatar Nov 08 '24 16:11 GiudGiud