Finish up a variety of modules' SQA missing items to be able to enforce checks
refs #15968
I noticed the number of SQA warnings was actually going up rather than down. Once the checks are enforced as errors and not warnings, this wont happen anymore. This PR enforces:
- 22 more items from warnings to errors across all modules
- peridynamics & contact with no more warnings
Job Documentation on ec528c3 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on ec528c3 wanted to post the following:
Framework coverage
Coverage did not change
Modules coverage
Phase field
| 45baf0 | #28464 ec528c | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 86.00% | 86.00% | +0.00% | 92.31% | |
| Hits | 13659 | 13679 | +20 | 24 | |
| Misses | 2224 | 2227 | +3 | 2 | |
Solid mechanics
| 45baf0 | #28464 ec528c | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 84.92% | 84.92% | -0.00% | 83.33% | |
| Hits | 28037 | 28047 | +10 | 10 | |
| Misses | 4977 | 4979 | +2 | 2 | |
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
thermal_hydraulics -
xfem
Warnings
-
solid_mechanicsnew line coverage rate 83.33% is less than the suggested 90.0%
This comment will be updated on new commits.
I can work on this review today a bit and hopefully finalize tomorrow.
interface got buggy but this was merged, then closed to attempt a "refresh" with close/reopen as the interface was frozen on "attempting to determine if PR can be merged"