idaholab
Improve Moving Boundary in `ElementSubdomainModifier`
This pull request addresses several problems with the moving_boundary_name in ElementSubdomainModifier. The biggest changes in this PR are:
- The creation of the
ElementSubdomainModifierBase - The removal of the
complement_moving_boundary_nameand the creation of the newmoving_boundary_subdomain_pairs.
This fixes:
- The
moving_boundary_namewas not updating correctly and thecomplement_moving_boundary_namewas being used instead. This redundancy has been removed, and the ability to choose which 'side' of the moving boundary to use is still retained. -
moving_boundary_subdomain_pairsnow gives control over the inclusion of new elements in the boundary. This is based on which pairs of subdomains the new elements are between. A notable extra capability here is the ability to include or exclude external surfaces in the moving boundary. - Segmentation fault for particular scenarios when running in parallel
This PR also fixes the issue of an adaptivity file (*-s0*.e) file being output at every time step. meshChanged() is now only called when at least one element changes its subdomain.
refs https://github.com/idaholab/moose/discussions/25736
@hugary1995
Job Documentation on 352a2d3 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on 352a2d3 wanted to post the following:
Framework coverage
| 0ef472 | #27965 352a2d | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.03% | 85.05% | +0.02% | 96.32% | |
| Hits | 105219 | 105254 | +35 | 314 | |
| Misses | 18526 | 18506 | -20 | 12 | |
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
Hello, this PR will cause some errors when testing malamute and racoon as the parameters have been changed for CoupledVarThresholdElementSubdomainModifier. I have made PRs to patch these. Thank you.
https://github.com/idaholab/malamute/pull/160 https://github.com/hugary1995/raccoon/pull/171
#28314 resulted in some conflicts in this PR. I resolved the conflicts (hopefully correctly) and force pushed to your branch. @Wendy-Ji let me know if I missed anything. I'm still reviewing this PR.
Since I am not an independent reviewer as I authored part of ElementSubdomainModifierBase.h/.C, we will need at least one approval from either @dewenyushu or @GiudGiud .
with regards to that last commit deleting the images, it s not enough to add a commit to delete the images. they are sitll in the commit history of the PR. you need to git rebase then edit the commit adding the images to truly remove them and the memory they take
with regards to that last commit deleting the images, it s not enough to add a commit to delete the images. they are sitll in the commit history of the PR. you need to git rebase then edit the commit adding the images to truly remove them and the memory they take
I believe this is resolved since all commits are squashed into one. Let me know otherwise.
I can do the independent CCB review tonight or tomorrow
That'd be great. Thanks!
@Wendy-Ji if you could update your malamute patch please. If you don't have time please just give me write access and I'll finish it up
@Wendy-Ji if you could update your malamute patch please. If you don't have time please just give me write access and I'll finish it up
The PR is still under review, but I think everything in the patch is up to date now. I've given you write access in case there's something else I've missed