idaholab
Add symmetry boundary conditions for linear FV.
Job Documentation on 4a79757 wanted to post the following:
View the site here
This comment will be updated on new commits.
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Updated the description, should be ready for an initial review! I'll rerun the flow test bed.
Job Documentation, step Docs: sync website on a6bbd6c wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage, step Generate coverage on a6bbd6c wanted to post the following:
Framework coverage
| 7edd10 | #27757 a6bbd6 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.97% | 85.97% | -0.00% | 100.00% | |
| Hits | 124954 | 124995 | +41 | 63 | |
| Misses | 20387 | 20395 | +8 | 0 | |
Modules coverage
Navier stokes
| 7edd10 | #27757 a6bbd6 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.54% | 85.54% | +0.00% | 100.00% | |
| Hits | 20323 | 20414 | +91 | 111 | |
| Misses | 3436 | 3450 | +14 | 0 | |
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
subchannel -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
Job Test, step Results summary on a6bbd6c wanted to post the following:
Framework test summary
Compared against 7edd10c in job civet.inl.gov/job/3374418.
Added tests
| Test | Time (s) |
|---|---|
linearfvbcs/scalar_symmetry.diffusion-2d-symmetry-nonorthogonal |
7.32 |
linearfvbcs/scalar_symmetry.advection-2d-symmetry-nonorthogonal |
6.98 |
linearfvkernels/diffusion.mms-diffusion-2d-rz-nonorthogonal |
6.38 |
linearfvbcs/scalar_symmetry.advection-2d-symmetry |
5.59 |
linearfvbcs/scalar_symmetry.diffusion-2d-symmetry |
5.38 |
linearfvbcs/scalar_symmetry.advection-1d-symmetry |
5.30 |
linearfvbcs/scalar_symmetry.diffusion-1d-symmetry |
5.18 |
Modules test summary
Compared against 7edd10c in job civet.inl.gov/job/3374418.
Removed tests
| Test | Time (s) |
|---|---|
navier_stokes/test:finite_volume/ins/turbulence/channel/linear-segregated.channel_ERCOFTAC_linear |
4.05 |
navier_stokes/test:finite_volume/ins/turbulence/channel/linear-segregated.channel_ERCOFTAC_linear_scaled_Re |
4.04 |
Added tests
| Test | Time (s) |
|---|---|
navier_stokes/test:finite_volume/ins/turbulence/channel/linear-segregated.channel_ERCOFTAC |
4.02 |
navier_stokes/test:finite_volume/ins/channel-flow/linear-segregated/2d-symmetric.symmetry/cartesian |
3.88 |
navier_stokes/test:finite_volume/ins/turbulence/channel/linear-segregated.channel_ERCOFTAC_scaled_Re |
3.54 |
navier_stokes/test:finite_volume/ins/channel-flow/linear-segregated/2d-symmetric.symmetry/rz |
3.30 |
navier_stokes/test:finite_volume/ins/turbulence/channel/linear-segregated.channel_ERCOFTAC_symmetry |
3.24 |
navier_stokes/test:finite_volume/ins/mms/linear-segregated/2d-symmetric-vortex.vortex-nonorthogonal |
SKIP |
navier_stokes/test:finite_volume/ins/mms/linear-segregated/2d-symmetric-vortex.vortex-orthogonal |
SKIP |
Tests have been done for quads/hexes and triangles including: -MMS for regular scalar symmetry and Navier Stokes -Channels and pipes give the analytical solution of a fully developed flow. -Turbulent channels yield the same velocity profile for a half channel with symmetry condition and a full channel.
There's a ticket of someone trying to do RZ symmetry linear FV. @grmnptr please reach back there to let them know it’s merged
