idaholab
XYDelaunayGenerator with Optimization Example
Job Documentation on 2de1910 wanted to post the following:
View the site here
This comment will be updated on new commits.
I would suggest implement a feature that allows reading interior points from a file, which would be particularly beneficial for managing extensive lists, potentially generated by a script.
Do you only need this list at the time of mesh generation? Or should the mesh be modified later
The Positions system would be good to use here. We would just have Positions be created earlier.
@GiudGiud
The Positions system would be good to use here. We would just have Positions be created earlier.
Are we going to create problems by doing this since some position objects rely on the mesh? Like the ElementCentroidPositions?
Positions is a GeneralUserObject, can we even run any use object before mesh creation or would this require us to add another execute_on flag?
There would be some work to do for sure
UOs are created in the problem which does not exist yet at that point
Job Coverage on 2de1910 wanted to post the following:
Framework coverage
| ca913d | #27723 2de191 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.08% | 85.08% | +0.00% | 100.00% | |
| Hits | 104117 | 104133 | +16 | 17 | |
| Misses | 18265 | 18265 | - | 0 | |
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
Job Documentation, step Docs: sync website on e578526 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage, step Generate coverage on e578526 wanted to post the following:
Framework coverage
| af6bed | #27723 e57852 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.09% | 85.10% | +0.00% | 100.00% | |
| Hits | 106734 | 106755 | +21 | 22 | |
| Misses | 18696 | 18696 | - | 0 | |
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
Testing failures unrelated: openmpi classic failures on multiapps coupling and some network issue on one of 2 HPC platforms
Few things here:
- Tests weren't ran on this PR in over 3 weeks, please consider invalidating before merge
- @maxnezdyur please consider adding valgrind testing to these optimization PRs. These tests tend to be more heavy than not and we've had multiple occurrences now where we've need to make one of the valgrind tests heavy
