moose
moose copied to clipboard
idaholab
Add physics for fully coupled k-epsilon
TODO:
- [ ] documentation
- [ ] add energy wall function
- [ ] add cross-parameter checking between BCs for energy & k-eps
- [ ] add cross-parameter checking between wall momentum and k-eps BCs
- [ ] expand testing reasonably. There are already 14 regression tests for turbulence trying out each wall function
It might take a bit to finish this. There's a lot, and a lot of options that don't work together. I ll get back to Components
Job Documentation on f72b921 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on f72b921 wanted to post the following:
Framework coverage
| 1da09a | #27614 f72b92 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.04% | 85.05% | +0.00% | 93.33% | |
| Hits | 105891 | 105904 | +13 | 14 | |
| Misses | 18622 | 18621 | -1 | 1 | |
Modules coverage
Navier stokes
| 1da09a | #27614 f72b92 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 84.54% | 84.59% | +0.04% | 83.87% | |
| Hits | 16356 | 16765 | +409 | 468 | |
| Misses | 2990 | 3055 | +65 | 90 | |
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
thermal_hydraulics -
xfem
Warnings
-
navier_stokesnew line coverage rate 83.87% is less than the suggested 90.0%
This comment will be updated on new commits.
Failure should be catchable in debug mode. I ll find it today or tomorrow, ready for a look otherwise
@tanoret this should be ready for review!
After this we should decide whether we take an intermediate step of adding segregated-nonlinear support to the Physics, or create an entire set of Physics for the linear solver
