idaholab
Adding interface area to two phase
@MengnanLi91 @grmnptr please take a look at your convenience.
The model has been validated against the experimental results in Hibiki and Ishii.
A simple version of two of the experiments in that paper is included in the test regression suite.
Thank you very much!
Job Documentation on 264aa30 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Precheck on ec8537f wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/27445/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format 639315765d5bfb1a99ac58caacdb50a4a3d7ee22
Job Coverage on 264aa30 wanted to post the following:
Framework coverage
| 5bf0d8 | #27445 264aa3 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.06% | 85.06% | -0.00% | - | |
| Hits | 104544 | 104543 | -1 | 0 | |
| Misses | 18360 | 18361 | +1 | 0 | |
Modules coverage
Navier stokes
| 5bf0d8 | #27445 264aa3 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 84.59% | 84.63% | +0.03% | 91.76% | |
| Hits | 16210 | 16288 | +78 | 78 | |
| Misses | 2952 | 2959 | +7 | 7 | |
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
@grmnptr Could you check if all your comments are addressed? I think this PR is ready to merge now
All good with this? I cannot find any comments left
Peter requested changes so he has to lift that before I can merge it
