moose
moose copied to clipboard
idaholab
Misc ray tracing changes
misc minor changes I needed for MaCaw
I might add another one based on Michael's input on slack needs a test
@mjseneca15
refs #26851 refs #26960
EDIT: this is ready for discussion
looks like some of these changes are not good for existing tests. I ll take this on later
Job Documentation on d82c811 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on d82c811 wanted to post the following:
Framework coverage
Coverage did not change
Modules coverage
Heat transfer
| e235a2 | #26852 d82c81 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 88.46% | 88.50% | +0.04% | 95.65% | |
| Hits | 4055 | 4077 | +22 | 22 | |
| Misses | 529 | 530 | +1 | 1 | |
Ray tracing
| e235a2 | #26852 d82c81 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 95.32% | 95.32% | -0.00% | 90.00% | |
| Hits | 4356 | 4355 | -1 | 9 | |
| Misses | 214 | 214 | - | 1 | |
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_mechanics -
solid_properties -
stochastic_tools -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
The more I think about it, the more changing the direction is not the right thing to do. It will bias results. Killing the ray or never starting it since it points the wrong direction will give better results