Update Optimization Module and remove duplicative code

[maxnezdyur]

closes #26564

[moosebuild]

Job Documentation on 93462ef wanted to post the following:

View the site here

This comment will be updated on new commits.

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[maxnezdyur]

Will work on soon.

[moosebuild]

Job Coverage on 93462ef wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Optimization

	b3efaa	#26565 93462e
	Total	Total	+/-	New
Rate	89.18%	88.61%	-0.57%	78.95%
Hits	2003	1976	-27	15
Misses	243	254	+11	4

Diff coverage report

Full coverage report

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_transfer
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• scalar_transport
• solid_mechanics
• solid_properties
• stochastic_tools
• thermal_hydraulics
• xfem

Warnings

• optimization new line coverage rate 78.95% is less than the suggested 90.0%

This comment will be updated on new commits.

[lynnmunday]

@maxnezdyur can close all of my comments, you have answered all of my questions. Great work. @GiudGiud I reviewed and it looks good, would you have time to review and merge?

[GiudGiud]

I ll do it soon!

[GiudGiud]

@lynnmunday note that because you edited my username into the previous comment, I never actually got a notification with that text