idaholab
Migrate NEML2 integration from blackbear to tensor mechanics
Job Documentation on 0a6c7f5 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Precheck on 0fe98d9 wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/26457/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format ad409367e365d3227cf9c1a0df63b3b9cde9b916
Ok, this should be ready. It builds successfully with NEML2 and passes the tests.
Job Coverage on 0a6c7f5 wanted to post the following:
Framework coverage
| c581c9 | #26457 0a6c7f | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.10% | 85.10% | +0.00% | 0.00% | |
| Hits | 98663 | 98665 | +2 | 0 | |
| Misses | 17273 | 17272 | -1 | 1 | |
Modules coverage
Inconsistent report tags were found between the head and base reports. This can happen when reports are missing from either the head or the base.
Inconsistent tags: module-tensor_mechanics-torch
Chemical reactions
| c581c9 | #26457 0a6c7f | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 92.53% | 92.48% | -0.05% | 50.00% | |
| Hits | 1437 | 1438 | +1 | 1 | |
| Misses | 116 | 117 | +1 | 1 | |
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_properties -
stochastic_tools -
tensor_mechanics -
thermal_hydraulics -
xfem
Warnings
-
frameworknew line coverage rate 0.00% is less than the suggested 90.0% -
chemical_reactionsnew line coverage rate 50.00% is less than the suggested 90.0%
This comment will be updated on new commits.
@dschwen you can let me know when you're ready for a review for the switching configuration
@dschwen you can let me know when you're ready for a review for the switching configuration
I'll address @GiudGiud 's review and prepare a PR for blackbear to remove everything NEML2. But functionally this is complete.
I suppose the best cause of action would be to remove NEML2 from Blackbear first so that we can see a clean pass on this PR.
For coverage I'm seeing
Not compiling MOOSE with NEML2 because NEML2_DIR is not a valid NEML2 checkout and/or libtorch is not enabled.
Also, while the thermochimica and NEML2 submodules are initialized they are not recursively initialized. This would lead to NEML2 build failures. (@loganharbour)
We cannot recursively enable submodules. Think about what would happen if you did this in Direwolf or BlueCRAB. We do have a mechanism though for enabling nested submodules though.
We cannot recursively enable submodules. Think about what would happen if you did this in Direwolf or BlueCRAB. We do have a mechanism though for enabling nested submodules though.
We can in moose. In most targets. And we'll need to until this is in.
We do nested submodules for sure and it works well. I can see us adapting the recipes for the transition period if you want to do that.
Yeah I guess constitutive models arent the same as properties. TM works for me
Job Precheck on adc94f7 wanted to post the following:
A change of the following file(s) triggered this check:
petsc
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml conda/petsc/meta.yaml
The PETSc submodule or configuration was changed but the conda build config was not
Job Precheck on adc94f7 wanted to post the following:
A change of the following file(s) triggered this check:
libmesh
The following file(s) are unchanged:
conda/mpich/conda_build_config.yaml conda/libmesh/meta.yaml
The libmesh submodule or configuration was changed but the conda build config was not
