moose icon indicating copy to clipboard operation
moose copied to clipboard

FlipSidesetGenerator

Open MohamedElkamash opened this issue 2 years ago • 3 comments

closes #25528

Reason

Sometimes the users need to flip a sideset and it would be nice if they don't go back to the meshing software

Design

This generator flips the sideset by changing the element attached to the sideset

Impact

New feature

MohamedElkamash avatar Dec 18 '23 19:12 MohamedElkamash

Job Documentation on 86328d9 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Dec 19 '23 18:12 moosebuild

Job Coverage on 86328d9 wanted to post the following:

Framework coverage

2584f7 #26363 86328d
Total Total +/- New
Rate 85.28% 85.29% +0.01% 96.77%
Hits 100756 100789 +33 30
Misses 17385 17383 -2 1

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

moosebuild avatar Jan 09 '24 00:01 moosebuild

What is the reason behind needing "Developer to activate" the tests? Mohamed previously pushed earlier in this PR and triggered tests fine -- am I missing something?

aprilnovak avatar Jan 25 '24 23:01 aprilnovak

This is really useful. I would suggest that an option should be added to specify which block the sideset should be with respect to. Sometimes these sidesets come in with somewhat random orientations, with some of the sides being with respect to one block, and others with respect to another block. Simply flipping them wouldn't actually be helpful, but making them all with respect to a specified block(s) would be. It would of course need to generate an error if there's not a neighbor belonging to the specified block.

bwspenc avatar Jan 29 '24 21:01 bwspenc

That's a good suggestion, can we add this in a separate issue because this one has taken long time?

MohamedElkamash avatar Jan 30 '24 00:01 MohamedElkamash

All jobs on fef6f2e : invalidated by @grmnptr

moosebuild avatar Feb 01 '24 23:02 moosebuild

I think the failures are unrelated.

aprilnovak avatar Feb 02 '24 22:02 aprilnovak

That's a good suggestion, can we add this in a separate issue because this one has taken long time?

That's fine!

bwspenc avatar Feb 13 '24 00:02 bwspenc

Job OpenMPI on fef6f2e : invalidated by @bwspenc

moosebuild avatar Feb 13 '24 00:02 moosebuild

failures look unrelated again?

aprilnovak avatar Feb 14 '24 01:02 aprilnovak

Yes OpenMPI just fails these days @aprilnovak are we good on Logan's comments?

GiudGiud avatar Feb 22 '24 20:02 GiudGiud

Thanks! And yep, they've been addressed in additional commits on this PR.

aprilnovak avatar Feb 22 '24 21:02 aprilnovak

taking over dont worry about the comments

GiudGiud avatar Feb 22 '24 22:02 GiudGiud

@MohamedElkamash could you please add me to your git repository? I cant seem to push to it. which is weird because " Maintainers are allowed to edit this pull request." is enabled.

GiudGiud avatar Feb 23 '24 00:02 GiudGiud

nevermind we re good here. Just need to wait for tests

GiudGiud avatar Feb 23 '24 00:02 GiudGiud