FlipSidesetGenerator
closes #25528
Reason
Sometimes the users need to flip a sideset and it would be nice if they don't go back to the meshing software
Design
This generator flips the sideset by changing the element attached to the sideset
Impact
New feature
Job Documentation on 86328d9 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on 86328d9 wanted to post the following:
Framework coverage
| 2584f7 | #26363 86328d | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.28% | 85.29% | +0.01% | 96.77% | |
| Hits | 100756 | 100789 | +33 | 30 | |
| Misses | 17385 | 17383 | -2 | 1 | |
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_properties -
stochastic_tools -
tensor_mechanics -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
What is the reason behind needing "Developer to activate" the tests? Mohamed previously pushed earlier in this PR and triggered tests fine -- am I missing something?
This is really useful. I would suggest that an option should be added to specify which block the sideset should be with respect to. Sometimes these sidesets come in with somewhat random orientations, with some of the sides being with respect to one block, and others with respect to another block. Simply flipping them wouldn't actually be helpful, but making them all with respect to a specified block(s) would be. It would of course need to generate an error if there's not a neighbor belonging to the specified block.
That's a good suggestion, can we add this in a separate issue because this one has taken long time?
All jobs on fef6f2e : invalidated by @grmnptr
I think the failures are unrelated.
That's a good suggestion, can we add this in a separate issue because this one has taken long time?
That's fine!
Job OpenMPI on fef6f2e : invalidated by @bwspenc
failures look unrelated again?
Yes OpenMPI just fails these days @aprilnovak are we good on Logan's comments?
Thanks! And yep, they've been addressed in additional commits on this PR.
taking over dont worry about the comments
@MohamedElkamash could you please add me to your git repository? I cant seem to push to it. which is weird because " Maintainers are allowed to edit this pull request." is enabled.
nevermind we re good here. Just need to wait for tests