Dynamic Rupture Earthquake Simulation Using Cohesive Zone Model and Slip Weakening Friction Law

[chunhuizhao478]

Closes #24642

[chunhuizhao478]

Hello!

I did a quick first pass. The application is definitely interesting Who is your contact at INL (if any)? In order to organize further review.

Hello! Thanks for your reply, I will look into them today. I'm at INL as intern right now, my contact is Robert Podgorney, I have talked with one of reviewers (jiangwen) yesterday.

[GiudGiud]

Ok great! I ll let them take over the review process for now. This is a strong start to adding this.

Should it be an example in the tensor mechanics module?

[chunhuizhao478]

Ok great! I ll let them take over the review process for now. This is a strong start to adding this.

Should it be an example in the tensor mechanics module?

Thanks! I think I have added two examples 2D_slipweakening, 3D_slipweakening in tensor_mechanics/test/tests/.

[GiudGiud]

I saw the inputs. There is just a slight nuance between tests and examples. Examples are easier to highlight in the documentation.

[chunhuizhao478]

I saw the inputs. There is just a slight nuance between tests and examples. Examples are easier to highlight in the documentation.

I see. So you would recommend I move them to examples?

[GiudGiud]

I ll let you work with Rob and Wen to determine that

[hugary1995]

Well Robert will have to make a decision, but my suggestion is to put this in MASTODON or BLACKBEAR.

[chunhuizhao478]

Well Robert will have to make a decision, but my suggestion is to put this in MASTODON or BLACKBEAR.

Thanks. So Cody arranged a meeting last week, people eventually agree to move the code in TensorMechanics

[hugary1995]

In that case, I second @GiudGiud 's suggestion -- please don't hard code numbers.

[hugary1995]

This PR probably needs some more work and review. But this is definitely an interesting capability!

[chunhuizhao478]

This PR probably needs some more work and review. But this is definitely an interesting capability!

Thanks! I will definitely take the comments seriously and discuss with framework people if needed

[chunhuizhao478]

Let s remove the merge commit and rebase instead

Sorry I'm new to this, how should I remove the merge commit and rebase? I try the following: git log --merges --oneline, find the [number] of second merge commit and do: git rebase -I [that number].

I'm not sure whether it's still there or not

[GiudGiud]

git rebase -i HEAD~3 then delete the merge commit (replace pick by d) then git fetch origin git rebase origin/devel (and deal with any conflict commit by commit, which is the nice part of rebasing)

[GiudGiud]

ok then dont do it that way

git reset --hard 38c002ffaa70ba4d4667c75b9dd6557c4b203b36 git cherry-pick e6892185989462a038c0440a503ebbeaf3267e46 git cherry-pick 129c0df4ca8675dd8599b9d5dd54f6b6efd875e9 git rebase origin/devel

[chunhuizhao478]

ok then dont do it that way

git reset --hard 38c002f git cherry-pick e689218 git cherry-pick 129c0df git rebase origin/devel

I tried this, but then it will have multiple pull and push commits, how should I deal with that?

[GiudGiud]

what do you mean push and pull commits?

[chunhuizhao478]

what do you mean push and pull commits?

okay, I switched to slipweakening branch, now it's fine

[chunhuizhao478]

Hi Guid, if you have time, could you please address the unresolved comments again? I'm working on the documentation, so which folder should I put the whole document in? And for each added object, I should have a separate documentation? @GiudGiud

[moosebuild]

Job Documentation on 403683d wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Coverage on 403683d wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Tensor mechanics

	dcbdc8	#24433 403683
	Total	Total	+/-	New
Rate	84.63%	84.71%	+0.08%	97.88%
Hits	25763	25948	+185	185
Misses	4679	4683	+4	4

Diff coverage report

Full coverage report

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_conduction
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• richards
• scalar_transport
• solid_properties
• stochastic_tools
• tensor_mechanics
• thermal_hydraulics
• xfem

This comment will be updated on new commits.

[loganharbour]

We need some help too figuring out the best place for extended documentation for this in TM.

Who from the TM side wants to review?

[GiudGiud]

I'm thinking this belongs in an example. @jiangwen84 what do you think?

[jiangwen84]

I'm thinking this belongs in an example. @jiangwen84 what do you think?

I agree. Example seems to be the way to go.

[GiudGiud]

ok let's move all the source code in src and include folders in a directory under moose/modules/tensor_mechanics/examples.

then for the docs you will want to put that there: modules/tensor_mechanics/examples and reference it in the example_index.md file

[chunhuizhao478]

@GiudGiud @loganharbour I'm not sure what to do about this "Conflicting files" large_media warning

[GiudGiud]

Dont worry about that. you may have to update the large media submodule again that s it

[chunhuizhao478]

@GiudGiud Hi Guid, I'm not sure why the code self-check is still in the queue? I think I have waited the check for weeks. Thanks!

[GiudGiud]

Hello

it s not automatically triggering for new contributors. I turned it on again manually. I d like to see other people s input on this work before we move forward

[rpodgorney]

@loganharbour @GiudGiud @dschwen @bwspenc @lynnmunday can you guys have a look at this--we need to move it along or get necessary feedback to the contributor. I can cover you time to review---

[jiangwen84]

@rpodgorney I had some discussion with @chunhuizhao478 for his codes. I will provide additional review.